You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Alejandro Abdelnur (JIRA)" <ji...@apache.org> on 2011/08/30 21:49:41 UTC
[jira] [Created] (HBASE-4302) don't do SNAPPY compression test
don't do SNAPPY compression test
--------------------------------
Key: HBASE-4302
URL: https://issues.apache.org/jira/browse/HBASE-4302
Project: HBase
Issue Type: Test
Components: test
Reporter: Alejandro Abdelnur
Assignee: Alejandro Abdelnur
The presence of the Snappy CODEC it does not mean that the Snappy JNI-bindings and native library are available.
Because of this it is not possible to assert SNAPPY compression
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4302) don't run SNAPPY compression test
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096527#comment-13096527 ]
Alejandro Abdelnur commented on HBASE-4302:
-------------------------------------------
After chatting with Todd, we may be able to get the test to work by trapping JNI related exceptions.
> don't run SNAPPY compression test
> ---------------------------------
>
> Key: HBASE-4302
> URL: https://issues.apache.org/jira/browse/HBASE-4302
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Attachments: HBASE-4302v1.patch
>
>
> The presence of the Snappy CODEC it does not mean that the Snappy JNI-bindings and native library are available.
> Because of this it is not possible to assert SNAPPY compression
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4302) don't run SNAPPY compression test
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096363#comment-13096363 ]
Todd Lipcon commented on HBASE-4302:
------------------------------------
Does SnappyCodec not provide any test/boolean to check whether the native libraries are available?
> don't run SNAPPY compression test
> ---------------------------------
>
> Key: HBASE-4302
> URL: https://issues.apache.org/jira/browse/HBASE-4302
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Attachments: HBASE-4302v1.patch
>
>
> The presence of the Snappy CODEC it does not mean that the Snappy JNI-bindings and native library are available.
> Because of this it is not possible to assert SNAPPY compression
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4302) don't run SNAPPY compression test
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HBASE-4302:
--------------------------------------
Summary: don't run SNAPPY compression test (was: don't do SNAPPY compression test)
> don't run SNAPPY compression test
> ---------------------------------
>
> Key: HBASE-4302
> URL: https://issues.apache.org/jira/browse/HBASE-4302
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Attachments: HBASE-4302v1.patch
>
>
> The presence of the Snappy CODEC it does not mean that the Snappy JNI-bindings and native library are available.
> Because of this it is not possible to assert SNAPPY compression
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4302) don't run SNAPPY compression test
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HBASE-4302:
--------------------------------------
Attachment: HBASE-4302v2.patch
'v2' does full coverage of cases:
* no Snappy SO
* no Hadoop SO
* Hadoop SO but no Snppy SO
* no Snappy Codec class
* Hadoop SO without Snappy JNI
Tested with all these combinations
> don't run SNAPPY compression test
> ---------------------------------
>
> Key: HBASE-4302
> URL: https://issues.apache.org/jira/browse/HBASE-4302
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Attachments: HBASE-4302v1.patch, HBASE-4302v2.patch
>
>
> The presence of the Snappy CODEC it does not mean that the Snappy JNI-bindings and native library are available.
> Because of this it is not possible to assert SNAPPY compression
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4302) don't run SNAPPY compression test
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096515#comment-13096515 ]
Alejandro Abdelnur commented on HBASE-4302:
-------------------------------------------
Actually you are right, it does, but it is wrong, HADOOP-7608.
Still, this will not fix the issue here in Hbase because we cannot use the SnappyCodec class directly, because it is not avail in currently released versions of Hadoop.
Thoughts?
> don't run SNAPPY compression test
> ---------------------------------
>
> Key: HBASE-4302
> URL: https://issues.apache.org/jira/browse/HBASE-4302
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Attachments: HBASE-4302v1.patch
>
>
> The presence of the Snappy CODEC it does not mean that the Snappy JNI-bindings and native library are available.
> Because of this it is not possible to assert SNAPPY compression
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4302) Only run Snappy compression tests
if Snappy is available
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099316#comment-13099316 ]
Hudson commented on HBASE-4302:
-------------------------------
Integrated in HBase-TRUNK #2183 (See [https://builds.apache.org/job/HBase-TRUNK/2183/])
HBASE-4302 Only run Snappy compression tests if Snappy is available
todd :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestCompressionTest.java
> Only run Snappy compression tests if Snappy is available
> --------------------------------------------------------
>
> Key: HBASE-4302
> URL: https://issues.apache.org/jira/browse/HBASE-4302
> Project: HBase
> Issue Type: Test
> Components: test
> Affects Versions: 0.92.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.92.0
>
> Attachments: HBASE-4302v1.patch, HBASE-4302v2.patch
>
>
> The presence of the Snappy CODEC it does not mean that the Snappy JNI-bindings and native library are available.
> Because of this it is not possible to assert SNAPPY compression
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4302) Only run Snappy compression tests if
Snappy is available
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HBASE-4302:
-------------------------------
Affects Version/s: 0.92.0
Fix Version/s: 0.92.0
Hadoop Flags: [Reviewed]
Summary: Only run Snappy compression tests if Snappy is available (was: don't run SNAPPY compression test)
> Only run Snappy compression tests if Snappy is available
> --------------------------------------------------------
>
> Key: HBASE-4302
> URL: https://issues.apache.org/jira/browse/HBASE-4302
> Project: HBase
> Issue Type: Test
> Components: test
> Affects Versions: 0.92.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.92.0
>
> Attachments: HBASE-4302v1.patch, HBASE-4302v2.patch
>
>
> The presence of the Snappy CODEC it does not mean that the Snappy JNI-bindings and native library are available.
> Because of this it is not possible to assert SNAPPY compression
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4302) don't do SNAPPY compression test
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HBASE-4302:
--------------------------------------
Status: Patch Available (was: Open)
> don't do SNAPPY compression test
> --------------------------------
>
> Key: HBASE-4302
> URL: https://issues.apache.org/jira/browse/HBASE-4302
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Attachments: HBASE-4302v1.patch
>
>
> The presence of the Snappy CODEC it does not mean that the Snappy JNI-bindings and native library are available.
> Because of this it is not possible to assert SNAPPY compression
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4302) Only run Snappy compression tests if
Snappy is available
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HBASE-4302:
-------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to trunk, thanks Alejandro
> Only run Snappy compression tests if Snappy is available
> --------------------------------------------------------
>
> Key: HBASE-4302
> URL: https://issues.apache.org/jira/browse/HBASE-4302
> Project: HBase
> Issue Type: Test
> Components: test
> Affects Versions: 0.92.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.92.0
>
> Attachments: HBASE-4302v1.patch, HBASE-4302v2.patch
>
>
> The presence of the Snappy CODEC it does not mean that the Snappy JNI-bindings and native library are available.
> Because of this it is not possible to assert SNAPPY compression
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4302) don't do SNAPPY compression test
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HBASE-4302:
--------------------------------------
Attachment: HBASE-4302v1.patch
> don't do SNAPPY compression test
> --------------------------------
>
> Key: HBASE-4302
> URL: https://issues.apache.org/jira/browse/HBASE-4302
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Attachments: HBASE-4302v1.patch
>
>
> The presence of the Snappy CODEC it does not mean that the Snappy JNI-bindings and native library are available.
> Because of this it is not possible to assert SNAPPY compression
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4302) don't run SNAPPY compression test
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099206#comment-13099206 ]
Todd Lipcon commented on HBASE-4302:
------------------------------------
+1
> don't run SNAPPY compression test
> ---------------------------------
>
> Key: HBASE-4302
> URL: https://issues.apache.org/jira/browse/HBASE-4302
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Attachments: HBASE-4302v1.patch, HBASE-4302v2.patch
>
>
> The presence of the Snappy CODEC it does not mean that the Snappy JNI-bindings and native library are available.
> Because of this it is not possible to assert SNAPPY compression
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira