You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/06 01:58:27 UTC
[GitHub] [flink] PatrickRen opened a new pull request #13072: [FLINK-18802][formats] Package uber jar including all dependencies for flink-avro
PatrickRen opened a new pull request #13072:
URL: https://github.com/apache/flink/pull/13072
## What is the purpose of the change
This pull request changes the pom.xml of flink-avro module in order to create a uber jar in packaging phase, including dependencies such as avro, jackson-core-asl, jackson-mapper-asl and joda-time.
## Brief change log
- Add another execution in maven-assembly-plugin to create a jar-with-dependencies
- Remove the "provided" scope and "optional" tag of joda-time dependency to include it in the uber jar
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #13072: [FLINK-18802][formats] Package uber jar including all dependencies for flink-avro
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #13072:
URL: https://github.com/apache/flink/pull/13072#issuecomment-683647507
Hey @PatrickRen,
I think it would be fine upgrading the avro version for the sql jar. We could even think of upgrading it straight to the 1.10 version. Again I very much agree with @twalthr that we can do that for the sql jar only.
In case of the {{flink-avro}} module the situation is not that easy. Users might've generated their classes against specific version. Moreover they might want to use the version of avro that comes with hadoop they're using. Therefore they should have an easy way to replace the avro version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on pull request #13072: [FLINK-18802][formats] Package uber jar including all dependencies for flink-avro
Posted by GitBox <gi...@apache.org>.
becketqin commented on pull request #13072:
URL: https://github.com/apache/flink/pull/13072#issuecomment-669645332
LGTM. We probably also want to have uber jars for other formats as well.
@wuchong Do you want to take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys closed pull request #13072: [FLINK-18802][formats] Package uber jar including all dependencies for flink-avro
Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #13072:
URL: https://github.com/apache/flink/pull/13072
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13072: [FLINK-18802][formats] Package uber jar including all dependencies for flink-avro
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13072:
URL: https://github.com/apache/flink/pull/13072#issuecomment-669640616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e9338aba347a925c5096dd4aafe439a90921ad",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5217",
"triggerID" : "69e9338aba347a925c5096dd4aafe439a90921ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 69e9338aba347a925c5096dd4aafe439a90921ad Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5217)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13072: [FLINK-18802][formats] Package uber jar including all dependencies for flink-avro
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13072:
URL: https://github.com/apache/flink/pull/13072#issuecomment-669640616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e9338aba347a925c5096dd4aafe439a90921ad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5217",
"triggerID" : "69e9338aba347a925c5096dd4aafe439a90921ad",
"triggerType" : "PUSH"
}, {
"hash" : "766339d0c1aac1c601b5796298f48b224584437c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5221",
"triggerID" : "766339d0c1aac1c601b5796298f48b224584437c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 69e9338aba347a925c5096dd4aafe439a90921ad Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5217)
* 766339d0c1aac1c601b5796298f48b224584437c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5221)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13072: [FLINK-18802][formats] Package uber jar including all dependencies for flink-avro
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13072:
URL: https://github.com/apache/flink/pull/13072#issuecomment-669640616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e9338aba347a925c5096dd4aafe439a90921ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5217",
"triggerID" : "69e9338aba347a925c5096dd4aafe439a90921ad",
"triggerType" : "PUSH"
}, {
"hash" : "766339d0c1aac1c601b5796298f48b224584437c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5221",
"triggerID" : "766339d0c1aac1c601b5796298f48b224584437c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 766339d0c1aac1c601b5796298f48b224584437c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5221)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PatrickRen commented on pull request #13072: [FLINK-18802][formats] Package uber jar including all dependencies for flink-avro
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on pull request #13072:
URL: https://github.com/apache/flink/pull/13072#issuecomment-669655364
Looks like CI failed. Fixed in 766339d
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13072: [FLINK-18802][formats] Package uber jar including all dependencies for flink-avro
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13072:
URL: https://github.com/apache/flink/pull/13072#issuecomment-669640616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e9338aba347a925c5096dd4aafe439a90921ad",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "69e9338aba347a925c5096dd4aafe439a90921ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 69e9338aba347a925c5096dd4aafe439a90921ad UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PatrickRen commented on pull request #13072: [FLINK-18802][formats] Package uber jar including all dependencies for flink-avro
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on pull request #13072:
URL: https://github.com/apache/flink/pull/13072#issuecomment-678949142
Thanks a lot @twalthr ~ What about upgrading Avro version to 1.9.0 so that we can get rid of joda-time, and packaging it into sql-jar as the default Avro version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13072: [FLINK-18802][formats] Package uber jar including all dependencies for flink-avro
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13072:
URL: https://github.com/apache/flink/pull/13072#issuecomment-669640616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e9338aba347a925c5096dd4aafe439a90921ad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5217",
"triggerID" : "69e9338aba347a925c5096dd4aafe439a90921ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 69e9338aba347a925c5096dd4aafe439a90921ad Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5217)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13072: [FLINK-18802][formats] Package uber jar including all dependencies for flink-avro
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13072:
URL: https://github.com/apache/flink/pull/13072#issuecomment-669640616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "69e9338aba347a925c5096dd4aafe439a90921ad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5217",
"triggerID" : "69e9338aba347a925c5096dd4aafe439a90921ad",
"triggerType" : "PUSH"
}, {
"hash" : "766339d0c1aac1c601b5796298f48b224584437c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "766339d0c1aac1c601b5796298f48b224584437c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 69e9338aba347a925c5096dd4aafe439a90921ad Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5217)
* 766339d0c1aac1c601b5796298f48b224584437c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13072: [FLINK-18802][formats] Package uber jar including all dependencies for flink-avro
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13072:
URL: https://github.com/apache/flink/pull/13072#issuecomment-669638015
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 69e9338aba347a925c5096dd4aafe439a90921ad (Thu Aug 06 02:00:19 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18802).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #13072: [FLINK-18802][formats] Package uber jar including all dependencies for flink-avro
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #13072:
URL: https://github.com/apache/flink/pull/13072#issuecomment-692700467
I am closing this PR because of inactivity and because it is subsumed by https://github.com/apache/flink/pull/13373 . Feel free to reopen if you think otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org