You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/10/27 10:16:09 UTC

[jira] Updated: (MPJCOVERAGE-20) allow comma separeted values for maven.jcoverage.instrumentation.excludes

The following issue has been updated:

    Updater: Tobias Joch (mailto:tojo@web.de)
       Date: Wed, 27 Oct 2004 4:15 AM
    Comment:
here is the patch as file...
    Changes:
             Attachment changed to patch.txt
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://jira.codehaus.org/browse/MPJCOVERAGE-20?page=history

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPJCOVERAGE-20

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPJCOVERAGE-20
    Summary: allow comma separeted values for maven.jcoverage.instrumentation.excludes
       Type: Improvement

     Status: Open
   Priority: Trivial

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-jcoverage-plugin
   Versions:
             1.0
             1.0.1
             1.0.2
             1.0.3
             1.0.4
             1.0.5
             1.0.6
             1.0.7
             1.0.8
             1.0.9

   Assignee: Emmanuel Venisse
   Reporter: Tobias Joch

    Created: Wed, 27 Oct 2004 4:13 AM
    Updated: Wed, 27 Oct 2004 4:15 AM

Description:
With following modification in the plugin.jelly a user can specify more than one exclude filters via maven.jcoverage.instrumentation.excludes (comma separeted).

Here the patch in the plugin.jelly:

Index: plugin.jelly
===================================================================
RCS file: /home/cvspublic/maven-plugins/jcoverage/plugin.jelly,v
retrieving revision 1.16
diff -u -r1.16 plugin.jelly
--- plugin.jelly	17 Aug 2004 14:00:48 -0000	1.16
+++ plugin.jelly	27 Oct 2004 08:09:25 -0000
@@ -121,10 +121,16 @@
       <maven:addPath id="maven.dependency.classpath" refid="jcoverage.classpath"/>
       <maven:addPath id="maven.dependency.classpath" refid="${pom.getDependencyClasspath()}"/>
 
+
+      <u:tokenize var="maven.jcoverage.instrumentation.excludes.split" delim=",">${maven.jcoverage.instrumentation.excludes}</u:tokenize>
+
       <instrument todir="${maven.jcoverage.instrumentation}">
-        <ant:fileset dir="${maven.build.dest}"
-            includes="${maven.jcoverage.instrumentation.includes}"
-            excludes="${maven.jcoverage.instrumentation.excludes}"/>
+      	<ant:fileset dir="${maven.build.dest}">
+	      	<ant:include name="**/*.class" />
+	      	<j:forEach var="var" items="${maven.jcoverage.instrumentation.excludes.split}">
+						<ant:exclude name="${var}" />
+		      </j:forEach>
+        </ant:fileset>
         <ant:classpath>
           <ant:path refid="jcoverage.classpath"/>
         </ant:classpath>
@@ -133,9 +139,12 @@
       <ant:copy todir="${maven.jcoverage.instrumentation}">
         <ant:fileset dir="${maven.build.dest}">
           <ant:exclude name="**/*.class" />
-          <ant:exclude name="${maven.jcoverage.instrumentation.excludes}" />
-        </ant:fileset>
+	      	<j:forEach var="var" items="${maven.jcoverage.instrumentation.excludes.split}">
+						<ant:exclude name="${var}" />
+		      </j:forEach>
+      	</ant:fileset>
       </ant:copy>
+
 
     </j:catch>
     <j:if test="${ex != null}">



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org