You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "rootvector2 (via GitHub)" <gi...@apache.org> on 2026/07/29 18:13:47 UTC
[PR] suppress case variants of mapped names in isPropertySuppressed [commons-beanutils]
rootvector2 opened a new pull request, #431:
URL: https://github.com/apache/commons-beanutils/pull/431
`isPropertySuppressed` compares the raw expression token against the suppressed set, but the mapped-descriptor fallback it guards builds `get<Base>(String)` / `set<Base>(String, ?)` from `MappedPropertyDescriptor.capitalizePropertyName(name)`, so any name that differs only in the case of its first character resolves the same accessor pair and is never matched by the check. With `mappedProperty` suppressed, `mappedProperty(key)` is blocked but `MappedProperty(key)` still reads and writes it, including through `BeanUtilsBean.populate` with a caller-supplied parameter map. Mapped accessors are never JavaBeans property descriptors, so `data.getDescriptor(name)` is always null for them and this check is the only thing in front of the accessor.
Comparing on the same capitalized base the descriptor derives keeps the guard and the descriptor from drifting apart again; `capitalizePropertyName` drops to package-private for that. Found while re-auditing the suppression path from #413.
`PropertyUtilsTest.testCustomIntrospectionSuppressedMappedPropertyCaseVariant` fails without the runtime change (`MappedProperty` still resolves a `MappedPropertyDescriptor`) and passes with it. Full `mvn` default goal is green: 1284 tests, 0 failures.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
- [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress case variants of mapped names in isPropertySuppressed [commons-beanutils]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #431:
URL: https://github.com/apache/commons-beanutils/pull/431#discussion_r3677675000
##########
src/main/java/org/apache/commons/beanutils2/PropertyUtilsBean.java:
##########
@@ -1068,15 +1068,21 @@ private Object invokeMethod(final Method method, final Object bean, final Object
/**
* Tests whether a property name has been removed by a registered {@link SuppressPropertiesBeanIntrospector}. The mapped-descriptor fallback in
* {@link #getPropertyDescriptor(Object, String)} bypasses the introspection pipeline, so suppressed mapped property names must be filtered explicitly.
+ * {@link MappedPropertyDescriptor} derives its accessor names from the capitalized property name, so names differing only in the case of their first
+ * character resolve the same accessors and are compared on that capitalized form here.
*
* @param name The property name to test.
* @return {@code true} if the name is suppressed by an introspector.
*/
private boolean isPropertySuppressed(final String name) {
+ final String base = MappedPropertyDescriptor.capitalizePropertyName(name);
for (final BeanIntrospector introspector : introspectors) {
- if (introspector instanceof SuppressPropertiesBeanIntrospector
- && ((SuppressPropertiesBeanIntrospector) introspector).getSuppressedProperties().contains(name)) {
- return true;
+ if (introspector instanceof SuppressPropertiesBeanIntrospector) {
+ for (final String suppressed : ((SuppressPropertiesBeanIntrospector) introspector).getSuppressedProperties()) {
+ if (base.equals(MappedPropertyDescriptor.capitalizePropertyName(suppressed))) {
Review Comment:
`SuppressPropertiesBeanIntrospector` only requires the collection itself to be non-null; it can still contain null entries. With the new capitalization comparison, a null suppressed name will now throw a `NullPointerException` in `capitalizePropertyName`, whereas previously it would just never match. Consider skipping null suppressed entries (or validating earlier) to keep this path robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress case variants of mapped names in isPropertySuppressed [commons-beanutils]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #431:
URL: https://github.com/apache/commons-beanutils/pull/431#issuecomment-5122937336
@rootvector2 see copilot comments. If you ran copilot on your own branch before creating a PR, we could save some time here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress case variants of mapped names in isPropertySuppressed [commons-beanutils]
Posted by "rootvector2 (via GitHub)" <gi...@apache.org>.
rootvector2 commented on PR #431:
URL: https://github.com/apache/commons-beanutils/pull/431#issuecomment-5143464686
Thanks for merging. Will do the 1.X port, though it's not a straight one: `getPropertyDescriptor` there has no suppression check in front of the `MappedPropertyDescriptor` fallback at all, so it needs the guard from #413 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress case variants of mapped names in isPropertySuppressed [commons-beanutils]
Posted by "rootvector2 (via GitHub)" <gi...@apache.org>.
rootvector2 commented on PR #431:
URL: https://github.com/apache/commons-beanutils/pull/431#issuecomment-5128410327
Addressed in `dbed349`: null entries in the suppressed set are skipped before capitalizing, since `SuppressPropertiesBeanIntrospector` only rejects a null collection and not null elements. Added `testCustomIntrospectionSuppressedMappedPropertyNullEntry`, which NPEs without the guard. Full `mvn` default goal is green, 1285 tests. Will run copilot on the branch before opening the next one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress case variants of mapped names in isPropertySuppressed [commons-beanutils]
Posted by "rootvector2 (via GitHub)" <gi...@apache.org>.
rootvector2 commented on code in PR #431:
URL: https://github.com/apache/commons-beanutils/pull/431#discussion_r3681158782
##########
src/main/java/org/apache/commons/beanutils2/PropertyUtilsBean.java:
##########
@@ -1068,15 +1068,21 @@ private Object invokeMethod(final Method method, final Object bean, final Object
/**
* Tests whether a property name has been removed by a registered {@link SuppressPropertiesBeanIntrospector}. The mapped-descriptor fallback in
* {@link #getPropertyDescriptor(Object, String)} bypasses the introspection pipeline, so suppressed mapped property names must be filtered explicitly.
+ * {@link MappedPropertyDescriptor} derives its accessor names from the capitalized property name, so names differing only in the case of their first
+ * character resolve the same accessors and are compared on that capitalized form here.
*
* @param name The property name to test.
* @return {@code true} if the name is suppressed by an introspector.
*/
private boolean isPropertySuppressed(final String name) {
+ final String base = MappedPropertyDescriptor.capitalizePropertyName(name);
for (final BeanIntrospector introspector : introspectors) {
- if (introspector instanceof SuppressPropertiesBeanIntrospector
- && ((SuppressPropertiesBeanIntrospector) introspector).getSuppressedProperties().contains(name)) {
- return true;
+ if (introspector instanceof SuppressPropertiesBeanIntrospector) {
+ for (final String suppressed : ((SuppressPropertiesBeanIntrospector) introspector).getSuppressedProperties()) {
+ if (base.equals(MappedPropertyDescriptor.capitalizePropertyName(suppressed))) {
Review Comment:
Good catch. `getSuppressedProperties` only guarantees the collection itself is non-null, so a null entry reached `capitalizePropertyName` and threw where the old `Set.contains` just never matched. Nulls are skipped in the loop now, with `testCustomIntrospectionSuppressedMappedPropertyNullEntry` covering it (NPEs without the guard).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress case variants of mapped names in isPropertySuppressed [commons-beanutils]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #431:
URL: https://github.com/apache/commons-beanutils/pull/431#issuecomment-5129999213
@rootvector2 Thank you, merged 🚀 , please port to 1.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress case variants of mapped names in isPropertySuppressed [commons-beanutils]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #431:
URL: https://github.com/apache/commons-beanutils/pull/431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org