You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by GitBox <gi...@apache.org> on 2021/08/22 07:06:05 UTC
[GitHub] [oodt] pavinduLakshan opened a new pull request #128: [OODT-1035][OODT-1037] Improve UI/UX of Workflow Manager Components in React.js OPSUI
pavinduLakshan opened a new pull request #128:
URL: https://github.com/apache/oodt/pull/128
Included changes:
1. Display past/present workflows in a paginated table view
2. Write new api endpoint to get paginated workflow pages
3. add missing api to the swagger api definitions
4. Implement triggering workflows by sending events from the OPSUI
5. Fix the issues mentioned in [OODT-1037](https://issues.apache.org/jira/projects/OODT/issues/OODT-1037?filter=allopenissues)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@oodt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [oodt] NGimhana commented on a change in pull request #128: [OODT-1035][OODT-1037] Improve UI/UX of Workflow Manager Components in React.js OPSUI
Posted by GitBox <gi...@apache.org>.
NGimhana commented on a change in pull request #128:
URL: https://github.com/apache/oodt/pull/128#discussion_r693685461
##########
File path: webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/resources/WorkflowInstanceResource.java
##########
@@ -56,10 +56,12 @@ public WorkflowInstanceResource(WorkflowInstance workflowInstance) {
this.workflowInstanceId = workflowInstance.getId();
this.currentTaskId = workflowInstance.getCurrentTaskId();
this.startDate = workflowInstance.getStartDate().toString();
- this.endDate = workflowInstance.getEndDate().toString();
this.timesBlocked = workflowInstance.getTimesBlocked();
this.sharedContext = new MetadataResource(workflowInstance.getSharedContext());
this.workflowState = new WorkflowStateResource(workflowInstance.getState());
+ if (workflowInstance.getEndDate() != null){
Review comment:
Shall we use StringUtils.isEmpty() for null check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@oodt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [oodt] pavinduLakshan commented on a change in pull request #128: [OODT-1035][OODT-1037] Improve UI/UX of Workflow Manager Components in React.js OPSUI
Posted by GitBox <gi...@apache.org>.
pavinduLakshan commented on a change in pull request #128:
URL: https://github.com/apache/oodt/pull/128#discussion_r693722112
##########
File path: webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/resources/WorkflowInstanceResource.java
##########
@@ -56,10 +56,12 @@ public WorkflowInstanceResource(WorkflowInstance workflowInstance) {
this.workflowInstanceId = workflowInstance.getId();
this.currentTaskId = workflowInstance.getCurrentTaskId();
this.startDate = workflowInstance.getStartDate().toString();
- this.endDate = workflowInstance.getEndDate().toString();
this.timesBlocked = workflowInstance.getTimesBlocked();
this.sharedContext = new MetadataResource(workflowInstance.getSharedContext());
this.workflowState = new WorkflowStateResource(workflowInstance.getState());
+ if (workflowInstance.getEndDate() != null){
Review comment:
But the `getEndDate()` returns a `Date`, not a string. As I found out `!= null` is the correct way to check if a `Date` is null, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@oodt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [oodt] NGimhana commented on a change in pull request #128: [OODT-1035][OODT-1037] Improve UI/UX of Workflow Manager Components in React.js OPSUI
Posted by GitBox <gi...@apache.org>.
NGimhana commented on a change in pull request #128:
URL: https://github.com/apache/oodt/pull/128#discussion_r693691003
##########
File path: webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/services/WMJaxrsServiceV2.java
##########
@@ -78,6 +79,50 @@ public WorkflowManagerStatus getWorkflowManagerStatus() {
}
}
+ /**
+ * returns all registered events
+ *
+ * @return events
+ */
+ @GET
+ @Path("events")
+ @Produces({MediaType.APPLICATION_JSON, MediaType.APPLICATION_XML})
+ public WorkflowEventListResource getRegisteredEvents() {
+ try {
+ WorkflowManagerClient wmclient = getContextClient();
+ List events = wmclient.getRegisteredEvents();
+ WorkflowEventListResource eventResource = new WorkflowEventListResource(events);
+ return eventResource;
+ } catch (WorkflowException e) {
Review comment:
Lets use multiple-catch in single line here because same body content is repeating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@oodt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [oodt] NGimhana merged pull request #128: [OODT-1035][OODT-1037] Improve UI/UX of Workflow Manager Components in React.js OPSUI
Posted by GitBox <gi...@apache.org>.
NGimhana merged pull request #128:
URL: https://github.com/apache/oodt/pull/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@oodt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org