[GitHub] [pinot] jackjlli commented on a diff in pull request #9092: Add consuming metadata to broker response

[GitBox <gi...@apache.org>]

jackjlli commented on code in PR #9092:
URL: https://github.com/apache/pinot/pull/9092#discussion_r929556462


##########
pinot-core/src/test/java/org/apache/pinot/core/operator/combine/SelectionCombineOperatorTest.java:
##########
@@ -84,9 +96,37 @@ public void setUp()
       throws Exception {
     FileUtils.deleteDirectory(TEMP_DIR);
     _indexSegments = new ArrayList<>(NUM_SEGMENTS);
-    for (int i = 0; i < NUM_SEGMENTS; i++) {
+    for (int i = 0; i < NUM_SEGMENTS / 2; i++) {

Review Comment:
   Can we rename the below `createSegment()` method to sth like `createOfflineSegment()` since you've added a new `createRealtimeSegment()` method here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org