[GitHub] [storm] bipinprasad commented on a change in pull request #3212: [STORM-3587] Allow Scheduler futureTask to gracefully exit with higher timeout.

[GitBox <gi...@apache.org>]

bipinprasad commented on a change in pull request #3212: [STORM-3587] Allow Scheduler futureTask to gracefully exit with higher timeout.
URL: https://github.com/apache/storm/pull/3212#discussion_r382822567
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
 ##########
 @@ -166,7 +166,7 @@ private void scheduleTopology(TopologyDetails td, Cluster cluster, final User to
                     Future<SchedulingResult> schedulingFuture = backgroundScheduling.submit(
                         () -> finalRasStrategy.schedule(toSchedule, td));
                     try {
-                        result = schedulingFuture.get(schedulingTimeoutSeconds, TimeUnit.SECONDS);
+                        result = schedulingFuture.get(schedulingTimeoutSeconds + 1, TimeUnit.SECONDS);
 
 Review comment:
   The timeout is check in strategy to determine when terminate. However, if the future task is killed at or around the same time - this results in a TimeOut exception on the task and the result is not propagated back to the caller. +1 gives an additional second before the FutureTask is rudely terminated and allows the result to be returned and examined for the actual message in the result.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services