You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "MieAh (via GitHub)" <gi...@apache.org> on 2023/04/02 09:25:36 UTC

[GitHub] [dubbo] MieAh commented on a diff in pull request #11981: Update demos (#11970)

MieAh commented on code in PR #11981:
URL: https://github.com/apache/dubbo/pull/11981#discussion_r1155217909


##########
dubbo-demo/dubbo-demo-native/dubbo-demo-native-consumer/pom.xml:
##########
@@ -51,6 +51,14 @@
             <groupId>org.apache.dubbo</groupId>
             <artifactId>dubbo-registry-zookeeper</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.dubbo</groupId>
+            <artifactId>dubbo-registry-nacos</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>com.alibaba.nacos</groupId>
+            <artifactId>nacos-client</artifactId>
+        </dependency>

Review Comment:
   plz remove useless dependencies.



##########
dubbo-demo/dubbo-demo-native/dubbo-demo-native-provider/pom.xml:
##########
@@ -50,6 +51,10 @@
             <groupId>org.apache.dubbo</groupId>
             <artifactId>dubbo-registry-zookeeper</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.dubbo</groupId>
+            <artifactId>dubbo-registry-nacos</artifactId>
+        </dependency>

Review Comment:
   be the same as the above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org