[jira] [Updated] (OAK-5862) Consistency check outputs wrong number of binary properties in debug messages

["Andrei Dulceanu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Dulceanu updated OAK-5862:
---------------------------------
    Attachment: OAK-5862.patch

I changed the place where the debug message is logged. Now this happens *after* actually checking the binary property. Below sample outputs for checking {{/a}} with and without binary check:

{code}
check . --filter /a --notify 0
Checking /a
Traversing /a
Checked 1 nodes and 0 properties
{code}

{code}
check . --filter /a --notify 0 --bin
Checking /a
Traversing /a
Checked /a/a0 = {2000 bytes}
Checked /a/a1 = {2000 bytes}
Checked /a/a2 = {2000 bytes}
Checked /a/a3 = {2000 bytes}
Checked /a/a4 = {2000 bytes}
Checked 1 nodes and 5 properties
{code}

[~mduerig], could you take a look at the patch, please?

> Consistency check outputs wrong number of binary properties in debug messages
> -----------------------------------------------------------------------------
>
>                 Key: OAK-5862
>                 URL: https://issues.apache.org/jira/browse/OAK-5862
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: run, segment-tar
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>             Fix For: 1.7.0, 1.8
>
>         Attachments: OAK-5862.patch
>
>
> {{check . --filter /a --notify 0}}
> Running above command for a node {{/a}} with 5 blob properties produces the following output:
> {code}
> Checking /a
> Traversing /a
> Checking /a/a0 = {2000 bytes}
> Checking /a/a1 = {2000 bytes}
> Checking /a/a2 = {2000 bytes}
> Checking /a/a3 = {2000 bytes}
> Checking /a/a4 = {2000 bytes}
> Checked 1 nodes and 0 properties
> {code}
> Although binary properties are not checked, wrong debug messages are being produced. Debug messages should match the final tally of properties checked which is correct.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)