[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9506: fix: replace mock tests with real tests in udp-logger

["monkeyDluffy6017 (via GitHub)" <gi...@apache.org>]

monkeyDluffy6017 commented on code in PR #9506:
URL: https://github.com/apache/apisix/pull/9506#discussion_r1201652124


##########
t/plugin/udp-logger.t:
##########
@@ -347,6 +348,12 @@ GET /t
                 return
             end
             ngx.say(body)
+            local code, _, _ = t("/hello", "GET")
+            if code >= 300 then
+                ngx.status = code
+                ngx.say("fail")
+                return
+            end

Review Comment:
   The test case's name is `add plugin`, but you also access the route in the test case, why not create a new test case to access? 
   ```
   === TEST 10: access
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org