You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/20 11:44:59 UTC

[GitHub] [airflow] potiuk opened a new pull request, #25847: Filter out non-editable apache-airflow from constraints.

potiuk opened a new pull request, #25847:
URL: https://github.com/apache/airflow/pull/25847

   The constraint files should not contain apache-airflow. So far
   apache-airflow has been automatically filtered out by the fact that it
   has been an editable installation and we filtered out all editable
   and file installations from `pip freeze`.
   
   However as of ~12 August 2022, likely setuptools change triggered
   a slight behaviour change when `eager-upgrade` installation of
   providers from PyPi was run in the CI image. Previously airflow
   remained an editable install, but as of 12th of August, such an
   installation causes removal of editable airlfow install and
   reinstalls it in non-editable mode. While this change is somewhat
   confusing, we have to protect against it and remove apache-airflow
   from `pip freeze` also in non-editable mode.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #25847: Filter out non-editable apache-airflow from constraints.

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25847:
URL: https://github.com/apache/airflow/pull/25847


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org