[GitHub] madlib pull request #262: MLP: Print loss of all iterations in verbose mode

[njayaram2 <gi...@git.apache.org>]

GitHub user njayaram2 opened a pull request:

    https://github.com/apache/madlib/pull/262

    MLP: Print loss of all iterations in verbose mode

    JIRA: MADLIB-1228
    
    - When verbose mode was set in mlp classification and regression training,
      the loss was printed only for 2 -> n-1 iterations. This commit fixes it
      and now prints loss for 1->n iterations (or whatever iteration
      convergence happens in).
    - This commit also fixes another bug that was discovered in
      __utils_normalize_data_grouping in utilis_regularization.py_in. The
      issue was that if grouping_col had more than one column specified in
      it, the query used for normalization used to error out due to
      ambiguity in column names referenced. This commit prefixes the table
      name while accessing the grouping column names now.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madlib/madlib bugfix/mlp/verbose-iteration-num

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/madlib/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #262
    
----
commit 6c0d19c027c5e5a750258d22936c894797e79f4f
Author: Nandish Jayaram <nj...@...>
Date:   2018-04-12T00:22:18Z

    MLP: Print loss of all iterations in verbose mode
    
    JIRA: MADLIB-1228
    
    - When verbose mode was set in mlp classification and regression training,
      the loss was printed only for 2 -> n-1 iterations. This commit fixes it
      and now prints loss for 1->n iterations (or whatever iteration
      convergence happens in).
    - This commit also fixes another bug that was discovered in
      __utils_normalize_data_grouping in utilis_regularization.py_in. The
      issue was that if grouping_col had more than one column specified in
      it, the query used for normalization used to error out due to
      ambiguity in column names referenced. This commit prefixes the table
      name while accessing the grouping column names now.

----


---

[GitHub] madlib issue #262: MLP: Print loss of all iterations in verbose mode

[asfgit <gi...@git.apache.org>]

Github user asfgit commented on the issue:

    https://github.com/apache/madlib/pull/262
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/madlib-pr-build/445/



---

[GitHub] madlib issue #262: MLP: Print loss of all iterations in verbose mode

[asfgit <gi...@git.apache.org>]

Github user asfgit commented on the issue:

    https://github.com/apache/madlib/pull/262
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/madlib-pr-build/443/



---

[GitHub] madlib pull request #262: MLP: Print loss of all iterations in verbose mode

[iyerr3 <gi...@git.apache.org>]

Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/262#discussion_r181394584
  
    --- Diff: src/ports/postgres/modules/convex/utils_regularization.py_in ---
    @@ -217,6 +217,11 @@ def __utils_normalize_data_grouping(y_decenter=True, **kwargs):
         """
         group_col = kwargs.get('grouping_col')
         group_col_list = split_quoted_delimited_str(group_col)
    +    # If more than one column was specified for grouping, prefix each column
    +    # name with '{tbl_data}.' to avoid ambiguity.
    +    select_grouping_cols = ', '.join(['{tbl_data}.{grp_col}'.format(
    --- End diff --
    
    Isn't there a function in utilities that was added for this? Maybe use that one for simplicity? 


---

[GitHub] madlib issue #262: MLP: Print loss of all iterations in verbose mode

[asfgit <gi...@git.apache.org>]

Github user asfgit commented on the issue:

    https://github.com/apache/madlib/pull/262
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/madlib-pr-build/449/



---

[GitHub] madlib pull request #262: MLP: Print loss of all iterations in verbose mode

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/madlib/pull/262


---