You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Vincent Lefevre <vi...@vinc17.org> on 2006/01/02 04:27:56 UTC
svnlook help is incomplete
"svnlook help changed" outputs:
changed: usage: svnlook changed REPOS_PATH
Print the paths that were changed.
Valid options:
-r [--revision] arg : specify revision number ARG
-t [--transaction] arg : specify transaction name ARG
But it doesn't say how the paths are printed. What is the exact
format? I think that "svnlook help changed" should say more.
Also, how are special characters encoded? In particular, what happens
when some filename contains the \n character? Of course, no-one would
normally use such a character in a filename, but I wonder about
security holes in hook scripts using svnlook.
--
Vincent Lefèvre <vi...@vinc17.org> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / SPACES project at LORIA
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svnlook help is incomplete
Posted by kf...@collab.net.
Vincent Lefevre <vi...@vinc17.org> writes:
> > Tentatively agreed. I don't want to get into the trap of making "help"
> > a complete specification for every command, but most of our commands do
> > describe at least the human-readable output formats in greater detail,
> > and "svnlook changed" does have magic code letters in its output.
>
> OK, but compared to "svn help status" and "svn help update",
> "svnlook help changed" doesn't contain very much (unless this
> has changed for 1.3.0).
I think Greg's agreeing with you :-).
Can you make a patch for this? That would be a big help.
(http://subversion.tigris.org/mailing-list-guidelines.html#patches,
which you're probably already familiar with, but I thought I'd give
the reference just in case.)
-Karl
--
www.collab.net <> CollabNet | Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svnlook help is incomplete
Posted by Vincent Lefevre <vi...@vinc17.org>.
On 2006-01-01 23:50:12 -0500, Greg Hudson wrote:
> On Mon, 2006-01-02 at 05:27 +0100, Vincent Lefevre wrote:
> > But it doesn't say how the paths are printed. What is the exact
> > format? I think that "svnlook help changed" should say more.
>
> Tentatively agreed. I don't want to get into the trap of making "help"
> a complete specification for every command, but most of our commands do
> describe at least the human-readable output formats in greater detail,
> and "svnlook changed" does have magic code letters in its output.
OK, but compared to "svn help status" and "svn help update",
"svnlook help changed" doesn't contain very much (unless this
has changed for 1.3.0).
--
Vincent Lefèvre <vi...@vinc17.org> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / SPACES project at LORIA
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svnlook help is incomplete
Posted by Greg Hudson <gh...@MIT.EDU>.
On Mon, 2006-01-02 at 05:27 +0100, Vincent Lefevre wrote:
> But it doesn't say how the paths are printed. What is the exact
> format? I think that "svnlook help changed" should say more.
Tentatively agreed. I don't want to get into the trap of making "help"
a complete specification for every command, but most of our commands do
describe at least the human-readable output formats in greater detail,
and "svnlook changed" does have magic code letters in its output.
> Also, how are special characters encoded? In particular, what happens
> when some filename contains the \n character? Of course, no-one would
> normally use such a character in a filename, but I wonder about
> security holes in hook scripts using svnlook.
\n is not allowed in Subversion filenames. I believe it is an open
issue that we don't guard against them, but neither our dump format nor
our FSFS back end will handle them correctly.
Filenames are stored in UTF-8 and converted to the local character set
for output. I don't believe any other encoding of special characters is
done by svnlook changed, though I haven't consulted the code to make
sure.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org