[GitHub] [incubator-superset] eschutho commented on a change in pull request #10834: fix dashboard edit/save errors

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #10834:
URL: https://github.com/apache/incubator-superset/pull/10834#discussion_r488283584



##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/save.test.js
##########
@@ -16,55 +16,118 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+
+import shortid from 'shortid';
 import readResponseBlob from '../../utils/readResponseBlob';
 import { WORLD_HEALTH_DASHBOARD } from './dashboard.helper';
 
 describe('Dashboard save action', () => {
-  let dashboardId;
-
   beforeEach(() => {
     cy.server();
     cy.login();
     cy.visit(WORLD_HEALTH_DASHBOARD);
+  });
 
-    cy.get('#app').then(data => {
-      const bootstrapData = JSON.parse(data[0].dataset.bootstrap);
-      const dashboard = bootstrapData.dashboard_data;
-      dashboardId = dashboard.id;
-      cy.route('POST', `/superset/copy_dash/${dashboardId}/`).as('copyRequest');
-    });
+  // it('should save as new dashboard', () => {

Review comment:
       👍 I uncommented it. Thanks for catching!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org