You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Giovanni Matteo Fumarola (JIRA)" <ji...@apache.org> on 2019/05/10 18:07:00 UTC
[jira] [Commented] (YARN-9453) Clean up code long if-else chain in
ApplicationCLI#run
[ https://issues.apache.org/jira/browse/YARN-9453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837496#comment-16837496 ]
Giovanni Matteo Fumarola commented on YARN-9453:
------------------------------------------------
Hi [~jiwq] please rebase the patch to master.
> Clean up code long if-else chain in ApplicationCLI#run
> ------------------------------------------------------
>
> Key: YARN-9453
> URL: https://issues.apache.org/jira/browse/YARN-9453
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Wanqiang Ji
> Priority: Major
> Labels: newbie
> Attachments: YARN-9453.001.patch, YARN-9453.002.patch, YARN-9453.003.patch
>
>
> org.apache.hadoop.yarn.client.cli.ApplicationCLI#run is 630 lines long, contains a long if-else chain and many many conditions.
> As a start, the bodies of the conditions could be extracted to methods and a more clean solution could be introduced to parse the argument values.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org