You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/05/20 13:38:28 UTC
[GitHub] [mynewt-core] kasjer opened a new pull request #2292: tinyusb: Add standard descriptor for BT HCI
kasjer opened a new pull request #2292:
URL: https://github.com/apache/mynewt-core/pull/2292
This allows to configure standard descriptor package to
build USB descriptor for Bluetooth HCI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2292: tinyusb: Add standard descriptor for BT HCI
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2292:
URL: https://github.com/apache/mynewt-core/pull/2292#issuecomment-631526827
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/usb/tinyusb/std_descriptors/src/std_descriptors.c
<details>
```diff
@@ -109,37 +109,37 @@
#endif /* CFG_TUD_HID */
const tusb_desc_device_t desc_device = {
- .bLength = sizeof(tusb_desc_device_t),
- .bDescriptorType = TUSB_DESC_DEVICE,
- .bcdUSB = 0x0200,
+ .bLength = sizeof(tusb_desc_device_t),
+ .bDescriptorType = TUSB_DESC_DEVICE,
+ .bcdUSB = 0x0200,
#if CFG_TUD_BTH
- .bDeviceClass = TUD_BT_APP_CLASS,
- .bDeviceSubClass = TUD_BT_APP_SUBCLASS,
- .bDeviceProtocol = TUD_BT_PROTOCOL_PRIMARY_CONTROLLER,
+ .bDeviceClass = TUD_BT_APP_CLASS,
+ .bDeviceSubClass = TUD_BT_APP_SUBCLASS,
+ .bDeviceProtocol = TUD_BT_PROTOCOL_PRIMARY_CONTROLLER,
#elif CFG_TUD_CDC
/*
* Use Interface Association Descriptor (IAD) for CDC
* As required by USB Specs IAD's subclass must be common class (2) and protocol must be IAD (1)
*/
- .bDeviceClass = TUSB_CLASS_MISC,
- .bDeviceSubClass = MISC_SUBCLASS_COMMON,
- .bDeviceProtocol = MISC_PROTOCOL_IAD,
+ .bDeviceClass = TUSB_CLASS_MISC,
+ .bDeviceSubClass = MISC_SUBCLASS_COMMON,
+ .bDeviceProtocol = MISC_PROTOCOL_IAD,
#else
- .bDeviceClass = 0x00,
- .bDeviceSubClass = 0x00,
- .bDeviceProtocol = 0x00,
-#endif
-
- .bMaxPacketSize0 = CFG_TUD_ENDPOINT0_SIZE,
-
- .idVendor = MYNEWT_VAL(USBD_VID),
- .idProduct = MYNEWT_VAL(USBD_PID),
- .bcdDevice = USBD_PRODUCT_RELEASE_NUMBER,
-
- .iManufacturer = 0x02,
- .iProduct = 0x03,
- .iSerialNumber = 0x01,
+ .bDeviceClass = 0x00,
+ .bDeviceSubClass = 0x00,
+ .bDeviceProtocol = 0x00,
+#endif
+
+ .bMaxPacketSize0 = CFG_TUD_ENDPOINT0_SIZE,
+
+ .idVendor = MYNEWT_VAL(USBD_VID),
+ .idProduct = MYNEWT_VAL(USBD_PID),
+ .bcdDevice = USBD_PRODUCT_RELEASE_NUMBER,
+
+ .iManufacturer = 0x02,
+ .iProduct = 0x03,
+ .iSerialNumber = 0x01,
.bNumConfigurations = 0x01
};
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2292: tinyusb: Add standard descriptor for BT HCI
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2292:
URL: https://github.com/apache/mynewt-core/pull/2292#issuecomment-631500689
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/usb/tinyusb/nrf5x/include/tusb_hw.h
<details>
```diff
@@ -79,7 +79,7 @@
#endif
#if defined(MYNEWT_VAL_USBD_BTH_EVENT_EP_SIZE)
-#defined BTH_EVENT_EP_SIZE MYNEWT_VAL(BTH_EVENT_EP_SIZE)
+#defined BTH_EVENT_EP_SIZE MYNEWT_VAL(BTH_EVENT_EP_SIZE)
#else
#define USBD_BTH_EVENT_EP_SIZE 0x10
#endif
```
</details>
#### hw/usb/tinyusb/std_descriptors/src/std_descriptors.c
<details>
```diff
@@ -190,7 +190,8 @@
MYNEWT_VAL(USBD_CONFIGURATION_MAX_POWER)),
#if CFG_TUD_BTH
- TUD_BTH_DESCRIPTOR(ITF_NUM_BTH, BTH_IF_STR_IX, USBD_BTH_EVENT_EP, USBD_BTH_EVENT_EP_SIZE, USBD_BTH_EVENT_EP_INTERVAL,
+ TUD_BTH_DESCRIPTOR(ITF_NUM_BTH, BTH_IF_STR_IX, USBD_BTH_EVENT_EP, USBD_BTH_EVENT_EP_SIZE,
+ USBD_BTH_EVENT_EP_INTERVAL,
USBD_BTH_DATA_IN_EP, USBD_BTH_DATA_OUT_EP, USBD_BTH_DATA_EP_SIZE, 0, 9, 17, 25, 33, 49),
#endif
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer merged pull request #2292: tinyusb: Add standard descriptor for BT HCI
Posted by GitBox <gi...@apache.org>.
kasjer merged pull request #2292:
URL: https://github.com/apache/mynewt-core/pull/2292
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2292: tinyusb: Add standard descriptor for BT HCI
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2292:
URL: https://github.com/apache/mynewt-core/pull/2292#issuecomment-631500689
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/usb/tinyusb/nrf5x/include/tusb_hw.h
<details>
```diff
@@ -79,7 +79,7 @@
#endif
#if defined(MYNEWT_VAL_USBD_BTH_EVENT_EP_SIZE)
-#defined BTH_EVENT_EP_SIZE MYNEWT_VAL(BTH_EVENT_EP_SIZE)
+#defined BTH_EVENT_EP_SIZE MYNEWT_VAL(BTH_EVENT_EP_SIZE)
#else
#define USBD_BTH_EVENT_EP_SIZE 0x10
#endif
```
</details>
#### hw/usb/tinyusb/std_descriptors/src/std_descriptors.c
<details>
```diff
@@ -190,7 +190,8 @@
MYNEWT_VAL(USBD_CONFIGURATION_MAX_POWER)),
#if CFG_TUD_BTH
- TUD_BTH_DESCRIPTOR(ITF_NUM_BTH, BTH_IF_STR_IX, USBD_BTH_EVENT_EP, USBD_BTH_EVENT_EP_SIZE, USBD_BTH_EVENT_EP_INTERVAL,
+ TUD_BTH_DESCRIPTOR(ITF_NUM_BTH, BTH_IF_STR_IX, USBD_BTH_EVENT_EP, USBD_BTH_EVENT_EP_SIZE,
+ USBD_BTH_EVENT_EP_INTERVAL,
USBD_BTH_DATA_IN_EP, USBD_BTH_DATA_OUT_EP, USBD_BTH_DATA_EP_SIZE, 0, 9, 17, 25, 33, 49),
#endif
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org