You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Artem Harutyunyan <ar...@mesosphere.io> on 2015/12/28 20:36:10 UTC
Re: Review Request 41705: Added support for enforcing quota on
(persistent) volumes (MESOS-4198).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41705/
-----------------------------------------------------------
(Updated Dec. 28, 2015, 11:36 a.m.)
Review request for mesos and Jie Yu.
Summary (updated)
-----------------
Added support for enforcing quota on (persistent) volumes (MESOS-4198).
Bugs: MESOS-4198
https://issues.apache.org/jira/browse/MESOS-4198
Repository: mesos
Description
-------
Added support for enforcing quota on (persistent) volumes (MESOS-4198).
Diffs
-----
src/slave/containerizer/mesos/isolators/posix/disk.cpp d971db09083faad08f3cf18c25a79245321d1d9a
src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d
Diff: https://reviews.apache.org/r/41705/diff/
Testing
-------
GTEST_FILTER='DiskQuotaTest*' make check -j8
Thanks,
Artem Harutyunyan
Re: Review Request 41705: Added support for enforcing quota on
(persistent) volumes (MESOS-4198).
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41705/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 8:57 a.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4198
https://issues.apache.org/jira/browse/MESOS-4198
Repository: mesos
Description
-------
Added support for enforcing quota on (persistent) volumes (MESOS-4198).
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/posix/disk.cpp d971db09083faad08f3cf18c25a79245321d1d9a
src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d
Diff: https://reviews.apache.org/r/41705/diff/
Testing
-------
GTEST_FILTER='DiskQuotaTest*' make check -j8
Thanks,
Artem Harutyunyan
Re: Review Request 41705: Added support for enforcing quota on
(persistent) volumes (MESOS-4198).
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41705/
-----------------------------------------------------------
(Updated Dec. 30, 2015, 4:01 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4198
https://issues.apache.org/jira/browse/MESOS-4198
Repository: mesos
Description
-------
Added support for enforcing quota on (persistent) volumes (MESOS-4198).
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/posix/disk.cpp d971db09083faad08f3cf18c25a79245321d1d9a
src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d
Diff: https://reviews.apache.org/r/41705/diff/
Testing
-------
GTEST_FILTER='DiskQuotaTest*' make check -j8
Thanks,
Artem Harutyunyan
Re: Review Request 41705: Added support for enforcing quota on
(persistent) volumes (MESOS-4198).
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
> On Dec. 30, 2015, 11:55 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/posix/disk.cpp, line 301
> > <https://reviews.apache.org/r/41705/diff/1/?file=1176049#file1176049line301>
> >
> > We may want to report volume usage through ResourceStatistics. This can be a separate ticket.
https://issues.apache.org/jira/browse/MESOS-4263
- Artem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41705/#review112343
-----------------------------------------------------------
On Dec. 30, 2015, 4:01 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41705/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2015, 4:01 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4198
> https://issues.apache.org/jira/browse/MESOS-4198
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for enforcing quota on (persistent) volumes (MESOS-4198).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/posix/disk.cpp d971db09083faad08f3cf18c25a79245321d1d9a
> src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d
>
> Diff: https://reviews.apache.org/r/41705/diff/
>
>
> Testing
> -------
>
> GTEST_FILTER='DiskQuotaTest*' make check -j8
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 41705: Added support for enforcing quota on
(persistent) volumes (MESOS-4198).
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41705/#review112343
-----------------------------------------------------------
Ship it!
src/slave/containerizer/mesos/isolators/posix/disk.cpp (line 186)
<https://reviews.apache.org/r/41705/#comment172819>
Can you do the following instead?
```
path = path::join(info->directory, path, "");
```
src/slave/containerizer/mesos/isolators/posix/disk.cpp (line 301)
<https://reviews.apache.org/r/41705/#comment172821>
We may want to report volume usage through ResourceStatistics. This can be a separate ticket.
src/tests/disk_quota_tests.cpp (line 221)
<https://reviews.apache.org/r/41705/#comment172824>
Do we still need this with implicit roles?
- Jie Yu
On Dec. 28, 2015, 7:36 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41705/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 7:36 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4198
> https://issues.apache.org/jira/browse/MESOS-4198
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for enforcing quota on (persistent) volumes (MESOS-4198).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/posix/disk.cpp d971db09083faad08f3cf18c25a79245321d1d9a
> src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d
>
> Diff: https://reviews.apache.org/r/41705/diff/
>
>
> Testing
> -------
>
> GTEST_FILTER='DiskQuotaTest*' make check -j8
>
>
> Thanks,
>
> Artem Harutyunyan
>
>