[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on a diff in pull request #557: [FLINK-31630] Limit max checkpoint age for last-state upgrade

["gaborgsomogyi (via GitHub)" <gi...@apache.org>]

gaborgsomogyi commented on code in PR #557:
URL: https://github.com/apache/flink-kubernetes-operator/pull/557#discussion_r1155680218


##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/TestingFlinkService.java:
##########
@@ -448,21 +435,46 @@ public List<String> getDisposedSavepoints() {
 
     @Override
     public Optional<Savepoint> getLastCheckpoint(JobID jobId, Configuration conf) throws Exception {
+        jobs.stream()
+                .filter(js -> js.f1.getJobId().equals(jobId))
+                .findAny()
+                .ifPresent(
+                        t -> {
+                            if (!t.f1.getJobState().isGloballyTerminalState()) {

Review Comment:
   Just for my own understanding why is it bad to call this? (I know it's copied over)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org