You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2017/11/11 13:42:32 UTC
Review Request 63744: Remove LockStore
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63744/
-----------------------------------------------------------
Review request for Aurora, Jordan Ly and Stephan Erb.
Repository: aurora
Description
-------
LockStore [entered](https://github.com/apache/aurora/commit/73e02c06b3accdd0a0e0fcdadf1ec1b46898767f) compatibility mode starting with 0.19.0, and can now be removed.
Diffs
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift c869493c06499340d73e1b219e17a0d7d8b5ead9
api/src/main/thrift/org/apache/aurora/gen/storage.thrift ccb58258249978c6752ca6994fdaf01fa196134c
src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java cedddf4603bbab73cd173e8f3d1ffceefaef37e4
src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 7ccdb11c6034e1b3e1bbfd3ca057ee87d271fea4
src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 992e950e29e80b29976cf1336ef7ea406603ab3c
src/main/java/org/apache/aurora/scheduler/state/LockManager.java 1a65b0802c9ce2b89c65137dddbdeef1a98c01f3
src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java ec05f50a8c8d919317c36c29ca4d2f8fa6b5a32f
src/main/java/org/apache/aurora/scheduler/state/StateModule.java d72f055749801ee9d6f31f60857cc795d0ed7ab1
src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 5b57399fc3e3b31c34b93b8693771863b0ae24f2
src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 9764a0102dd74b020abcbed7b96394d5e1b98591
src/main/java/org/apache/aurora/scheduler/storage/Storage.java 7e810abdca3cc53626692845987de74ba6c564aa
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 3c9bae4e825e853c8d92d82cef2c5cb29c5aae56
src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 32588794bd2c62f3e1eeee38113053e698e281de
src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java a5b58e8e6c8dd3c4dccaefaa246b6058c46c9197
src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobUpdateStore.java d190add5601cbe4d5d302136a0476cfe4ed2b9bb
src/main/java/org/apache/aurora/scheduler/storage/mem/MemLockStore.java 4c7bda8031fc76a2f1b74df0fde00692953c28ee
src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 7ace1040615a7e484f54d83e55111db504a0a542
src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 2ad84eb1d5e4746ce1c4e18e54fd31fe377eb743
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 534ae597f5c93eddcc7fc8f55e5d13390914d391
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 27c0b43b9ca10fb79a8c38b0df9d4e3f43999b36
src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 8301b19f53670a5da36d8713d8e7384578bf281e
src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 8e19794e21cc1490d62b7c7122042c5f8af37a5a
src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 5c82bcfbe6eca68f5926677cb22e95cb5f627189
src/test/java/org/apache/aurora/scheduler/storage/AbstractLockStoreTest.java b6fd02780156d6f76a43d580f53b21145e67d52b
src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 08579744b36b0aa08a87cd9fc532b8b40c439a36
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 17e75c5427dd4139467791d5c6bfb7a621dacccf
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java 5a28f0ba9325624d8a139f1ce844d6a00082d59b
src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java 13726cc11ab09cd4995233d9d31811b97b065275
src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java 4019d1a48cb8aeb028610b30d0dd4b110d1e7aca
src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 21d26b3930ea965487b2dec48a48a98677ba022b
src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 43e32eede27bbf26363a3fd1ca34ffe6f8c01a73
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 1691477e8995756580162c460a82d20b82140c2d
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4d62bba3eb64be4493dc80a1cee93159a4828c12
Diff: https://reviews.apache.org/r/63744/diff/1/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 63744: Remove LockStore
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63744/#review190780
-----------------------------------------------------------
Master (9b9b2ee) is red with this patch.
./build-support/jenkins/build.sh
^
symbol: class LockKey
location: class ShiroAuthorizingParamInterceptor
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java:110: error: cannot find symbol
new ThriftFieldGetter<>(Lock.class, Lock._Fields.KEY, LockKey.class);
^
symbol: class Lock
location: class ShiroAuthorizingParamInterceptor
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java:110: error: package Lock does not exist
new ThriftFieldGetter<>(Lock.class, Lock._Fields.KEY, LockKey.class);
^
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java:110: error: cannot find symbol
new ThriftFieldGetter<>(Lock.class, Lock._Fields.KEY, LockKey.class);
^
symbol: class LockKey
location: class ShiroAuthorizingParamInterceptor
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java:113: error: cannot find symbol
new ThriftFieldGetter<>(LockKey.class, LockKey._Fields.JOB, JobKey.class);
^
symbol: class LockKey
location: class ShiroAuthorizingParamInterceptor
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java:113: error: package LockKey does not exist
new ThriftFieldGetter<>(LockKey.class, LockKey._Fields.JOB, JobKey.class);
^
10 errors
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 58s
16 actionable tasks: 10 executed, 6 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 11, 2017, 1:42 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63744/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2017, 1:42 p.m.)
>
>
> Review request for Aurora, Jordan Ly and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> LockStore [entered](https://github.com/apache/aurora/commit/73e02c06b3accdd0a0e0fcdadf1ec1b46898767f) compatibility mode starting with 0.19.0, and can now be removed.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift c869493c06499340d73e1b219e17a0d7d8b5ead9
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift ccb58258249978c6752ca6994fdaf01fa196134c
> src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java cedddf4603bbab73cd173e8f3d1ffceefaef37e4
> src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 7ccdb11c6034e1b3e1bbfd3ca057ee87d271fea4
> src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 992e950e29e80b29976cf1336ef7ea406603ab3c
> src/main/java/org/apache/aurora/scheduler/state/LockManager.java 1a65b0802c9ce2b89c65137dddbdeef1a98c01f3
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java ec05f50a8c8d919317c36c29ca4d2f8fa6b5a32f
> src/main/java/org/apache/aurora/scheduler/state/StateModule.java d72f055749801ee9d6f31f60857cc795d0ed7ab1
> src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 5b57399fc3e3b31c34b93b8693771863b0ae24f2
> src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 9764a0102dd74b020abcbed7b96394d5e1b98591
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 7e810abdca3cc53626692845987de74ba6c564aa
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 3c9bae4e825e853c8d92d82cef2c5cb29c5aae56
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 32588794bd2c62f3e1eeee38113053e698e281de
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java a5b58e8e6c8dd3c4dccaefaa246b6058c46c9197
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobUpdateStore.java d190add5601cbe4d5d302136a0476cfe4ed2b9bb
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemLockStore.java 4c7bda8031fc76a2f1b74df0fde00692953c28ee
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 7ace1040615a7e484f54d83e55111db504a0a542
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 2ad84eb1d5e4746ce1c4e18e54fd31fe377eb743
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 534ae597f5c93eddcc7fc8f55e5d13390914d391
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 27c0b43b9ca10fb79a8c38b0df9d4e3f43999b36
> src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 8301b19f53670a5da36d8713d8e7384578bf281e
> src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 8e19794e21cc1490d62b7c7122042c5f8af37a5a
> src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 5c82bcfbe6eca68f5926677cb22e95cb5f627189
> src/test/java/org/apache/aurora/scheduler/storage/AbstractLockStoreTest.java b6fd02780156d6f76a43d580f53b21145e67d52b
> src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 08579744b36b0aa08a87cd9fc532b8b40c439a36
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 17e75c5427dd4139467791d5c6bfb7a621dacccf
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java 5a28f0ba9325624d8a139f1ce844d6a00082d59b
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java 13726cc11ab09cd4995233d9d31811b97b065275
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java 4019d1a48cb8aeb028610b30d0dd4b110d1e7aca
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 21d26b3930ea965487b2dec48a48a98677ba022b
> src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 43e32eede27bbf26363a3fd1ca34ffe6f8c01a73
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 1691477e8995756580162c460a82d20b82140c2d
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4d62bba3eb64be4493dc80a1cee93159a4828c12
>
>
> Diff: https://reviews.apache.org/r/63744/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 63744: Remove LockStore
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63744/#review190792
-----------------------------------------------------------
Ship it!
Looks good to me. Feel free to ship it once the build is green.
- Stephan Erb
On Nov. 11, 2017, 2:42 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63744/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2017, 2:42 p.m.)
>
>
> Review request for Aurora, Jordan Ly and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> LockStore [entered](https://github.com/apache/aurora/commit/73e02c06b3accdd0a0e0fcdadf1ec1b46898767f) compatibility mode starting with 0.19.0, and can now be removed.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift c869493c06499340d73e1b219e17a0d7d8b5ead9
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift ccb58258249978c6752ca6994fdaf01fa196134c
> src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java cedddf4603bbab73cd173e8f3d1ffceefaef37e4
> src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 7ccdb11c6034e1b3e1bbfd3ca057ee87d271fea4
> src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 992e950e29e80b29976cf1336ef7ea406603ab3c
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 474a403318604bee7f10bdcb444fe6c27fdd5804
> src/main/java/org/apache/aurora/scheduler/state/LockManager.java 1a65b0802c9ce2b89c65137dddbdeef1a98c01f3
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java ec05f50a8c8d919317c36c29ca4d2f8fa6b5a32f
> src/main/java/org/apache/aurora/scheduler/state/StateModule.java d72f055749801ee9d6f31f60857cc795d0ed7ab1
> src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 5b57399fc3e3b31c34b93b8693771863b0ae24f2
> src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 9764a0102dd74b020abcbed7b96394d5e1b98591
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 7e810abdca3cc53626692845987de74ba6c564aa
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 3c9bae4e825e853c8d92d82cef2c5cb29c5aae56
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 32588794bd2c62f3e1eeee38113053e698e281de
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java a5b58e8e6c8dd3c4dccaefaa246b6058c46c9197
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobUpdateStore.java d190add5601cbe4d5d302136a0476cfe4ed2b9bb
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemLockStore.java 4c7bda8031fc76a2f1b74df0fde00692953c28ee
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 7ace1040615a7e484f54d83e55111db504a0a542
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 2ad84eb1d5e4746ce1c4e18e54fd31fe377eb743
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 534ae597f5c93eddcc7fc8f55e5d13390914d391
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 27c0b43b9ca10fb79a8c38b0df9d4e3f43999b36
> src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 8301b19f53670a5da36d8713d8e7384578bf281e
> src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 8e19794e21cc1490d62b7c7122042c5f8af37a5a
> src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 5c82bcfbe6eca68f5926677cb22e95cb5f627189
> src/test/java/org/apache/aurora/scheduler/storage/AbstractLockStoreTest.java b6fd02780156d6f76a43d580f53b21145e67d52b
> src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 08579744b36b0aa08a87cd9fc532b8b40c439a36
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 17e75c5427dd4139467791d5c6bfb7a621dacccf
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java 5a28f0ba9325624d8a139f1ce844d6a00082d59b
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java 13726cc11ab09cd4995233d9d31811b97b065275
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java 4019d1a48cb8aeb028610b30d0dd4b110d1e7aca
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 21d26b3930ea965487b2dec48a48a98677ba022b
> src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 43e32eede27bbf26363a3fd1ca34ffe6f8c01a73
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 1691477e8995756580162c460a82d20b82140c2d
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4d62bba3eb64be4493dc80a1cee93159a4828c12
>
>
> Diff: https://reviews.apache.org/r/63744/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 63744: Remove LockStore
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63744/#review190787
-----------------------------------------------------------
Master (9b9b2ee) is red with this patch.
./build-support/jenkins/build.sh
src/test/python/apache/aurora/common/test_clusters.py::test_load [32mPASSED[0m
src/test/python/apache/aurora/common/test_clusters.py::test_load_invalid_syntax [32mPASSED[0m
src/test/python/apache/aurora/common/test_clusters.py::test_patch_cleanup_on_error [32mPASSED[0m
src/test/python/apache/aurora/common/test_shellify.py::test_shellify [32mPASSED[0m
src/test/python/apache/aurora/common/test_cluster.py::test_simple [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_construction [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_finish_with_ephemerals [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_finish_with_daemons [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_finish_with_daemon_ephemerals [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_process_cannot_depend_upon_daemon [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_non_ephemeral_process_cannot_depend_on_ephemeral_process [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_failed_predecessor_does_not_make_process_runnable [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_daemon_duration [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_waits [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_fails [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_lost [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_filters [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_max_runs [32mPASSED[0m
src/test/python/apache/thermos/common/test_pathspec.py::test_legacy_task_roots [32mPASSED[0m
src/test/python/apache/thermos/common/test_pathspec.py::test_legacy_log_dirs [32mPASSED[0m
src/test/python/apache/thermos/common/test_pathspec.py::test_exception_on_none_keys [32mPASSED[0m
src/test/python/apache/thermos/common/test_planner.py::test_planner_empty [32mPASSED[0m
src/test/python/apache/thermos/common/test_planner.py::test_planner_unordered [32mPASSED[0m
src/test/python/apache/thermos/common/test_planner.py::test_planner_ordered [32mPASSED[0m
src/test/python/apache/thermos/common/test_planner.py::test_planner_mixed [32mPASSED[0m
src/test/python/apache/thermos/common/test_planner.py::test_planner_unsatisfiables [32mPASSED[0m
===================== ERRORS =====================
ERROR collecting src/test/python/apache/aurora/client/api/test_scheduler_client.py
src/test/python/apache/aurora/client/api/test_scheduler_client.py:36: in <module>
[1m from gen.apache.aurora.api.ttypes import ([0m
[1m[31mE ImportError: cannot import name Lock[0m
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/aaf4d108c31293299a0839bdc404a91802f80937.xml
[1m[31m 719 passed, 6 skipped, 1 warnings, 1 error in 278.95 seconds [0m
FAILURE
03:04:17 05:16 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 11, 2017, 9:42 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63744/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2017, 9:42 p.m.)
>
>
> Review request for Aurora, Jordan Ly and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> LockStore [entered](https://github.com/apache/aurora/commit/73e02c06b3accdd0a0e0fcdadf1ec1b46898767f) compatibility mode starting with 0.19.0, and can now be removed.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift c869493c06499340d73e1b219e17a0d7d8b5ead9
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift ccb58258249978c6752ca6994fdaf01fa196134c
> src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java cedddf4603bbab73cd173e8f3d1ffceefaef37e4
> src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 7ccdb11c6034e1b3e1bbfd3ca057ee87d271fea4
> src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 992e950e29e80b29976cf1336ef7ea406603ab3c
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 474a403318604bee7f10bdcb444fe6c27fdd5804
> src/main/java/org/apache/aurora/scheduler/state/LockManager.java 1a65b0802c9ce2b89c65137dddbdeef1a98c01f3
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java ec05f50a8c8d919317c36c29ca4d2f8fa6b5a32f
> src/main/java/org/apache/aurora/scheduler/state/StateModule.java d72f055749801ee9d6f31f60857cc795d0ed7ab1
> src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 5b57399fc3e3b31c34b93b8693771863b0ae24f2
> src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 9764a0102dd74b020abcbed7b96394d5e1b98591
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 7e810abdca3cc53626692845987de74ba6c564aa
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 3c9bae4e825e853c8d92d82cef2c5cb29c5aae56
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 32588794bd2c62f3e1eeee38113053e698e281de
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java a5b58e8e6c8dd3c4dccaefaa246b6058c46c9197
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobUpdateStore.java d190add5601cbe4d5d302136a0476cfe4ed2b9bb
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemLockStore.java 4c7bda8031fc76a2f1b74df0fde00692953c28ee
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 7ace1040615a7e484f54d83e55111db504a0a542
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 2ad84eb1d5e4746ce1c4e18e54fd31fe377eb743
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 534ae597f5c93eddcc7fc8f55e5d13390914d391
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 27c0b43b9ca10fb79a8c38b0df9d4e3f43999b36
> src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 8301b19f53670a5da36d8713d8e7384578bf281e
> src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 8e19794e21cc1490d62b7c7122042c5f8af37a5a
> src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 5c82bcfbe6eca68f5926677cb22e95cb5f627189
> src/test/java/org/apache/aurora/scheduler/storage/AbstractLockStoreTest.java b6fd02780156d6f76a43d580f53b21145e67d52b
> src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 08579744b36b0aa08a87cd9fc532b8b40c439a36
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 17e75c5427dd4139467791d5c6bfb7a621dacccf
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java 5a28f0ba9325624d8a139f1ce844d6a00082d59b
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java 13726cc11ab09cd4995233d9d31811b97b065275
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java 4019d1a48cb8aeb028610b30d0dd4b110d1e7aca
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 21d26b3930ea965487b2dec48a48a98677ba022b
> src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 43e32eede27bbf26363a3fd1ca34ffe6f8c01a73
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 1691477e8995756580162c460a82d20b82140c2d
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4d62bba3eb64be4493dc80a1cee93159a4828c12
>
>
> Diff: https://reviews.apache.org/r/63744/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 63744: Remove LockStore
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63744/#review190895
-----------------------------------------------------------
Ship it!
Master (bd12188) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 11, 2017, 5:42 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63744/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2017, 5:42 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> LockStore [entered](https://github.com/apache/aurora/commit/73e02c06b3accdd0a0e0fcdadf1ec1b46898767f) compatibility mode starting with 0.19.0, and can now be removed.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift c869493c06499340d73e1b219e17a0d7d8b5ead9
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 74983babb4fe433baab7af0f8bfbdebeb4b28e74
> src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java cedddf4603bbab73cd173e8f3d1ffceefaef37e4
> src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 7ccdb11c6034e1b3e1bbfd3ca057ee87d271fea4
> src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 992e950e29e80b29976cf1336ef7ea406603ab3c
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 474a403318604bee7f10bdcb444fe6c27fdd5804
> src/main/java/org/apache/aurora/scheduler/state/LockManager.java 1a65b0802c9ce2b89c65137dddbdeef1a98c01f3
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java ec05f50a8c8d919317c36c29ca4d2f8fa6b5a32f
> src/main/java/org/apache/aurora/scheduler/state/StateModule.java d72f055749801ee9d6f31f60857cc795d0ed7ab1
> src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 5b57399fc3e3b31c34b93b8693771863b0ae24f2
> src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 9764a0102dd74b020abcbed7b96394d5e1b98591
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 7e810abdca3cc53626692845987de74ba6c564aa
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 3c9bae4e825e853c8d92d82cef2c5cb29c5aae56
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 6462b801017b67dd279dba35ef908e12cadc5bd4
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java a5b58e8e6c8dd3c4dccaefaa246b6058c46c9197
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobUpdateStore.java d190add5601cbe4d5d302136a0476cfe4ed2b9bb
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemLockStore.java 4c7bda8031fc76a2f1b74df0fde00692953c28ee
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 7ace1040615a7e484f54d83e55111db504a0a542
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 2ad84eb1d5e4746ce1c4e18e54fd31fe377eb743
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 534ae597f5c93eddcc7fc8f55e5d13390914d391
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 27c0b43b9ca10fb79a8c38b0df9d4e3f43999b36
> src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 8301b19f53670a5da36d8713d8e7384578bf281e
> src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 8e19794e21cc1490d62b7c7122042c5f8af37a5a
> src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 5c82bcfbe6eca68f5926677cb22e95cb5f627189
> src/test/java/org/apache/aurora/scheduler/storage/AbstractLockStoreTest.java b6fd02780156d6f76a43d580f53b21145e67d52b
> src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java bcc7438e6b6b845f3c869be1e3588ea6f7361b06
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 17e75c5427dd4139467791d5c6bfb7a621dacccf
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java 2d161c8885feb20178764a1b8a969b9488c46a50
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java 13726cc11ab09cd4995233d9d31811b97b065275
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java 4019d1a48cb8aeb028610b30d0dd4b110d1e7aca
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 21d26b3930ea965487b2dec48a48a98677ba022b
> src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 43e32eede27bbf26363a3fd1ca34ffe6f8c01a73
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 1691477e8995756580162c460a82d20b82140c2d
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4d62bba3eb64be4493dc80a1cee93159a4828c12
> src/test/python/apache/aurora/client/api/test_scheduler_client.py f61f73a9ad8127e9428f34cf3ad717665fa244c8
>
>
> Diff: https://reviews.apache.org/r/63744/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 63744: Remove LockStore
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63744/#review190890
-----------------------------------------------------------
This patch does not apply cleanly against RB#63743 (e0624b2), do you need to rebase?
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 11, 2017, 1:42 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63744/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2017, 1:42 p.m.)
>
>
> Review request for Aurora, Jordan Ly and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> LockStore [entered](https://github.com/apache/aurora/commit/73e02c06b3accdd0a0e0fcdadf1ec1b46898767f) compatibility mode starting with 0.19.0, and can now be removed.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift c869493c06499340d73e1b219e17a0d7d8b5ead9
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 74983babb4fe433baab7af0f8bfbdebeb4b28e74
> src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java cedddf4603bbab73cd173e8f3d1ffceefaef37e4
> src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 7ccdb11c6034e1b3e1bbfd3ca057ee87d271fea4
> src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 992e950e29e80b29976cf1336ef7ea406603ab3c
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 474a403318604bee7f10bdcb444fe6c27fdd5804
> src/main/java/org/apache/aurora/scheduler/state/LockManager.java 1a65b0802c9ce2b89c65137dddbdeef1a98c01f3
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java ec05f50a8c8d919317c36c29ca4d2f8fa6b5a32f
> src/main/java/org/apache/aurora/scheduler/state/StateModule.java d72f055749801ee9d6f31f60857cc795d0ed7ab1
> src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 5b57399fc3e3b31c34b93b8693771863b0ae24f2
> src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 9764a0102dd74b020abcbed7b96394d5e1b98591
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 7e810abdca3cc53626692845987de74ba6c564aa
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 3c9bae4e825e853c8d92d82cef2c5cb29c5aae56
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 6462b801017b67dd279dba35ef908e12cadc5bd4
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java a5b58e8e6c8dd3c4dccaefaa246b6058c46c9197
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobUpdateStore.java d190add5601cbe4d5d302136a0476cfe4ed2b9bb
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemLockStore.java 4c7bda8031fc76a2f1b74df0fde00692953c28ee
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 7ace1040615a7e484f54d83e55111db504a0a542
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 2ad84eb1d5e4746ce1c4e18e54fd31fe377eb743
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 534ae597f5c93eddcc7fc8f55e5d13390914d391
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 27c0b43b9ca10fb79a8c38b0df9d4e3f43999b36
> src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 8301b19f53670a5da36d8713d8e7384578bf281e
> src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 8e19794e21cc1490d62b7c7122042c5f8af37a5a
> src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 5c82bcfbe6eca68f5926677cb22e95cb5f627189
> src/test/java/org/apache/aurora/scheduler/storage/AbstractLockStoreTest.java b6fd02780156d6f76a43d580f53b21145e67d52b
> src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java bcc7438e6b6b845f3c869be1e3588ea6f7361b06
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 17e75c5427dd4139467791d5c6bfb7a621dacccf
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java 2d161c8885feb20178764a1b8a969b9488c46a50
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java 13726cc11ab09cd4995233d9d31811b97b065275
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java 4019d1a48cb8aeb028610b30d0dd4b110d1e7aca
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 21d26b3930ea965487b2dec48a48a98677ba022b
> src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 43e32eede27bbf26363a3fd1ca34ffe6f8c01a73
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 1691477e8995756580162c460a82d20b82140c2d
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4d62bba3eb64be4493dc80a1cee93159a4828c12
> src/test/python/apache/aurora/client/api/test_scheduler_client.py f61f73a9ad8127e9428f34cf3ad717665fa244c8
>
>
> Diff: https://reviews.apache.org/r/63744/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 63744: Remove LockStore
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63744/#review190797
-----------------------------------------------------------
Master (9b9b2ee) is red with this patch.
./build-support/jenkins/build.sh
import org.apache.ibatis.migration.MigrationScript;
^
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/migration/V001_CreateAppcImagesTable.java:20: error: cannot find symbol
public class V001_CreateAppcImagesTable implements MigrationScript {
^
symbol: class MigrationScript
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/migration/V007_CreateMesosFetcherURIsTable.java:18: error: package org.apache.ibatis.migration does not exist
import org.apache.ibatis.migration.MigrationScript;
^
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/migration/V007_CreateMesosFetcherURIsTable.java:20: error: cannot find symbol
public class V007_CreateMesosFetcherURIsTable implements MigrationScript {
^
symbol: class MigrationScript
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/migration/V006_PopulateTierField.java:18: error: package org.apache.ibatis.migration does not exist
import org.apache.ibatis.migration.MigrationScript;
^
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/migration/V006_PopulateTierField.java:20: error: cannot find symbol
public class V006_PopulateTierField implements MigrationScript {
^
symbol: class MigrationScript
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java:138: warning: [cast] redundant cast to getDataSource
return (T) sessionFactory.getConfiguration().getEnvironment().getDataSource();
^
100 errors
1 warning
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 1m 12s
16 actionable tasks: 10 executed, 6 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 11, 2017, 1:42 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63744/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2017, 1:42 p.m.)
>
>
> Review request for Aurora, Jordan Ly and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> LockStore [entered](https://github.com/apache/aurora/commit/73e02c06b3accdd0a0e0fcdadf1ec1b46898767f) compatibility mode starting with 0.19.0, and can now be removed.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift c869493c06499340d73e1b219e17a0d7d8b5ead9
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift ccb58258249978c6752ca6994fdaf01fa196134c
> src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java cedddf4603bbab73cd173e8f3d1ffceefaef37e4
> src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 7ccdb11c6034e1b3e1bbfd3ca057ee87d271fea4
> src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 992e950e29e80b29976cf1336ef7ea406603ab3c
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 474a403318604bee7f10bdcb444fe6c27fdd5804
> src/main/java/org/apache/aurora/scheduler/state/LockManager.java 1a65b0802c9ce2b89c65137dddbdeef1a98c01f3
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java ec05f50a8c8d919317c36c29ca4d2f8fa6b5a32f
> src/main/java/org/apache/aurora/scheduler/state/StateModule.java d72f055749801ee9d6f31f60857cc795d0ed7ab1
> src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 5b57399fc3e3b31c34b93b8693771863b0ae24f2
> src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 9764a0102dd74b020abcbed7b96394d5e1b98591
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 7e810abdca3cc53626692845987de74ba6c564aa
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 3c9bae4e825e853c8d92d82cef2c5cb29c5aae56
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 32588794bd2c62f3e1eeee38113053e698e281de
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java a5b58e8e6c8dd3c4dccaefaa246b6058c46c9197
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobUpdateStore.java d190add5601cbe4d5d302136a0476cfe4ed2b9bb
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemLockStore.java 4c7bda8031fc76a2f1b74df0fde00692953c28ee
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 7ace1040615a7e484f54d83e55111db504a0a542
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 2ad84eb1d5e4746ce1c4e18e54fd31fe377eb743
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 534ae597f5c93eddcc7fc8f55e5d13390914d391
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 27c0b43b9ca10fb79a8c38b0df9d4e3f43999b36
> src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 8301b19f53670a5da36d8713d8e7384578bf281e
> src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 8e19794e21cc1490d62b7c7122042c5f8af37a5a
> src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 5c82bcfbe6eca68f5926677cb22e95cb5f627189
> src/test/java/org/apache/aurora/scheduler/storage/AbstractLockStoreTest.java b6fd02780156d6f76a43d580f53b21145e67d52b
> src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 08579744b36b0aa08a87cd9fc532b8b40c439a36
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 17e75c5427dd4139467791d5c6bfb7a621dacccf
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java 5a28f0ba9325624d8a139f1ce844d6a00082d59b
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java 13726cc11ab09cd4995233d9d31811b97b065275
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java 4019d1a48cb8aeb028610b30d0dd4b110d1e7aca
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 21d26b3930ea965487b2dec48a48a98677ba022b
> src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 43e32eede27bbf26363a3fd1ca34ffe6f8c01a73
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 1691477e8995756580162c460a82d20b82140c2d
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4d62bba3eb64be4493dc80a1cee93159a4828c12
> src/test/python/apache/aurora/client/api/test_scheduler_client.py f61f73a9ad8127e9428f34cf3ad717665fa244c8
>
>
> Diff: https://reviews.apache.org/r/63744/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 63744: Remove LockStore
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63744/#review190891
-----------------------------------------------------------
@ReviewBot retry
The 'Depends on' field is now blank, not sure why the bot tried to use it again.
- Bill Farner
On Nov. 11, 2017, 5:42 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63744/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2017, 5:42 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> LockStore [entered](https://github.com/apache/aurora/commit/73e02c06b3accdd0a0e0fcdadf1ec1b46898767f) compatibility mode starting with 0.19.0, and can now be removed.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift c869493c06499340d73e1b219e17a0d7d8b5ead9
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 74983babb4fe433baab7af0f8bfbdebeb4b28e74
> src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java cedddf4603bbab73cd173e8f3d1ffceefaef37e4
> src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 7ccdb11c6034e1b3e1bbfd3ca057ee87d271fea4
> src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 992e950e29e80b29976cf1336ef7ea406603ab3c
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 474a403318604bee7f10bdcb444fe6c27fdd5804
> src/main/java/org/apache/aurora/scheduler/state/LockManager.java 1a65b0802c9ce2b89c65137dddbdeef1a98c01f3
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java ec05f50a8c8d919317c36c29ca4d2f8fa6b5a32f
> src/main/java/org/apache/aurora/scheduler/state/StateModule.java d72f055749801ee9d6f31f60857cc795d0ed7ab1
> src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 5b57399fc3e3b31c34b93b8693771863b0ae24f2
> src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 9764a0102dd74b020abcbed7b96394d5e1b98591
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 7e810abdca3cc53626692845987de74ba6c564aa
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 3c9bae4e825e853c8d92d82cef2c5cb29c5aae56
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 6462b801017b67dd279dba35ef908e12cadc5bd4
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java a5b58e8e6c8dd3c4dccaefaa246b6058c46c9197
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobUpdateStore.java d190add5601cbe4d5d302136a0476cfe4ed2b9bb
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemLockStore.java 4c7bda8031fc76a2f1b74df0fde00692953c28ee
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 7ace1040615a7e484f54d83e55111db504a0a542
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 2ad84eb1d5e4746ce1c4e18e54fd31fe377eb743
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 534ae597f5c93eddcc7fc8f55e5d13390914d391
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 27c0b43b9ca10fb79a8c38b0df9d4e3f43999b36
> src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 8301b19f53670a5da36d8713d8e7384578bf281e
> src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 8e19794e21cc1490d62b7c7122042c5f8af37a5a
> src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 5c82bcfbe6eca68f5926677cb22e95cb5f627189
> src/test/java/org/apache/aurora/scheduler/storage/AbstractLockStoreTest.java b6fd02780156d6f76a43d580f53b21145e67d52b
> src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java bcc7438e6b6b845f3c869be1e3588ea6f7361b06
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 17e75c5427dd4139467791d5c6bfb7a621dacccf
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java 2d161c8885feb20178764a1b8a969b9488c46a50
> src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java 13726cc11ab09cd4995233d9d31811b97b065275
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java 4019d1a48cb8aeb028610b30d0dd4b110d1e7aca
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 21d26b3930ea965487b2dec48a48a98677ba022b
> src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 43e32eede27bbf26363a3fd1ca34ffe6f8c01a73
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 1691477e8995756580162c460a82d20b82140c2d
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 4d62bba3eb64be4493dc80a1cee93159a4828c12
> src/test/python/apache/aurora/client/api/test_scheduler_client.py f61f73a9ad8127e9428f34cf3ad717665fa244c8
>
>
> Diff: https://reviews.apache.org/r/63744/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>