[GitHub] [trafficcontrol] rob05c commented on issue #3701: Add pagination support for TO API endpoints that use BuildWhereAndOrderBy

[GitBox <gi...@apache.org>]

rob05c commented on issue #3701: Add pagination support for TO API endpoints that use BuildWhereAndOrderBy
URL: https://github.com/apache/trafficcontrol/pull/3701#issuecomment-508823374
 
 
   My biggest concern with merging code without docs, and I suspect @ocket8888 's as well, is that it never gets done. But I see @rawlinp 's point as well, about docs being outdated before we even release.
   
   If we merge code without docs, IMO it should be a requirement before merging that a Github Issue be created for making those docs, and put in the milestone of the next release, to be sure don't release without adding them.
   
   In fact, I'd propose adding it to the PR template, "This PR includes documentation OR I have explained why documentation is unnecessary OR I have created a Github Issue for the documentation and worked with a Committer to place it in the next Milestone."
   
   How does that sound?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services