You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by mhthanh <gi...@git.apache.org> on 2014/10/07 07:47:43 UTC
[GitHub] tajo pull request: TAJO-1097: IllegalArgumentException: RawFileSca...
GitHub user mhthanh opened a pull request:
https://github.com/apache/tajo/pull/183
TAJO-1097: IllegalArgumentException: RawFileScanner
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mhthanh/tajo TAJO-1097
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/183.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #183
----
commit de9f7112731e4053613252e4e7e2d924020f5b0a
Author: mhthanh <ma...@gmail.com>
Date: 2014-10-07T05:43:35Z
TAJO-1097
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1097: IllegalArgumentException: RawFileSca...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/183#discussion_r18511422
--- Diff: tajo-storage/src/main/java/org/apache/tajo/storage/RawFile.java ---
@@ -151,7 +151,11 @@ private boolean fillBuffer() throws IOException {
long realRemaining = fragment.getEndKey() - numBytesRead;
numBytesRead += bytesRead;
if (realRemaining < bufferSize) {
- buffer.limit(currentDataSize + (int) realRemaining);
+ int newLimit = currentDataSize + (int) realRemaining;
+ if(newLimit > bufferSize) {
+ newLimit = bufferSize;
+ }
+ buffer.limit(newLimit);
--- End diff --
I think we don't need buffer.limit. we already check the EOF condition in next().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1097: IllegalArgumentException: RawFileSca...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---