[GitHub] [geode-benchmarks] pivotal-jbarrett commented on a change in pull request #130: initial implementation of withClusterTopology

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on a change in pull request #130:
URL: https://github.com/apache/geode-benchmarks/pull/130#discussion_r453098098



##########
File path: geode-benchmarks/build.gradle
##########
@@ -93,6 +93,7 @@ task benchmark(type: Test) {
   }
   systemProperty 'withSsl', project.hasProperty('withSsl')
   systemProperty 'withSniProxy', project.hasProperty('withSniProxy')
+  systemProperty 'withClusterTopology', project.hasProperty('withSniProxy')

Review comment:
       I think you want `project.hasProperty('withSniProxy')`.

##########
File path: geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/GeodeBenchmark.java
##########
@@ -45,11 +46,20 @@ public static TestConfig createConfig() {
     config.durationSeconds(BENCHMARK_DURATION);
     config.threads(THREADS);
 
-    final String sniProp = System.getProperty("withSniProxy");
-    final boolean doSni = sniProp != null && !sniProp.equals("false");
+    String prop = System.getProperty("withSniProxy");

Review comment:
       `Boolean.getBoolean(name)` returns false if the property is missing or exists but is not "true".
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org