[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3809: drivers/spi: Change prefix to a more intuitive "spislave"

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #3809:
URL: https://github.com/apache/incubator-nuttx/pull/3809#discussion_r642615051



##########
File path: include/nuttx/spi/slave.h
##########
@@ -561,7 +561,7 @@ struct spi_sdev_s
  ****************************************************************************/
 
 #ifdef CONFIG_SPI_SLAVE_DRIVER
-int spislv_register(FAR struct spi_sctrlr_s *sctrlr, int bus);
+int spislave_register(FAR struct spi_sctrlr_s *sctrlr, int bus);

Review comment:
       should we use spi_sdev_ prefix instead just like spi_sdev_s/spi_sdevops_s?

##########
File path: drivers/spi/spi_slave_driver.c
##########
@@ -57,7 +57,7 @@
  * Private Types
  ****************************************************************************/
 
-struct spislv_driver_s
+struct spislave_driver_s

Review comment:
       should we give the driver a special name? since it is most used for simple echo testing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org