You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/21 09:09:21 UTC
[GitHub] [kafka] dajac opened a new pull request #8525: [WIP] KAFKA-9885; Evict last members of a group when the maximum allowed is reached
dajac opened a new pull request #8525:
URL: https://github.com/apache/kafka/pull/8525
WIP
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #8525: KAFKA-9885; Evict last members of a group when the maximum allowed is reached
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #8525:
URL: https://github.com/apache/kafka/pull/8525#discussion_r414737521
##########
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##########
@@ -124,6 +124,35 @@ class GroupCoordinator(val brokerId: Int,
info("Shutdown complete.")
}
+ /**
+ * Verify if the group has space to accept the joining member. The various
+ * criteria are explained bellow.
Review comment:
typo: `bellow`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #8525: KAFKA-9885; Evict last members of a group when the maximum allowed is reached
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #8525:
URL: https://github.com/apache/kafka/pull/8525#issuecomment-619001260
Related to #8437.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #8525: KAFKA-9885; Evict last members of a group when the maximum allowed is reached
Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #8525:
URL: https://github.com/apache/kafka/pull/8525#issuecomment-619142257
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #8525: KAFKA-9885; Evict last members of a group when the maximum allowed is reached
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #8525:
URL: https://github.com/apache/kafka/pull/8525#issuecomment-618992102
cc @hachikuji @abbccdda
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org