You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by fr...@apache.org on 2022/10/11 02:29:28 UTC
[druid] branch master updated: process: update PR template to include release notes (#13188)
This is an automated email from the ASF dual-hosted git repository.
frankchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 2a24c20454 process: update PR template to include release notes (#13188)
2a24c20454 is described below
commit 2a24c20454ea16487cca500ad89410c93f1b54e4
Author: 317brian <53...@users.noreply.github.com>
AuthorDate: Mon Oct 10 19:29:18 2022 -0700
process: update PR template to include release notes (#13188)
* process: update PR template to include release notes
* Update .github/pull_request_template.md [ci skip]
Co-authored-by: Charles Smith <te...@gmail.com>
* Update .github/pull_request_template.md
Co-authored-by: Clint Wylie <cj...@gmail.com>
* incorporate feedback from paul
Co-authored-by: Charles Smith <te...@gmail.com>
Co-authored-by: Clint Wylie <cj...@gmail.com>
---
.github/pull_request_template.md | 11 +++++++++++
CONTRIBUTING.md | 39 +++++++++++++++++++++++++++++++++++++++
2 files changed, 50 insertions(+)
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index abf7ed5b1d..8c518a050a 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -37,6 +37,15 @@ In each section, please describe design decisions made, including:
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
+#### Release note
+<!-- Give your best effort to summarize your changes in a couple of sentences aimed toward Druid users.
+
+If your change doesn't have end user impact, you can skip this section.
+
+-->
+For tips about how to write a good release note, see [Release notes](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#release-notes).
+
+
<hr>
##### Key changed/added classes in this PR
@@ -49,9 +58,11 @@ In each section, please describe design decisions made, including:
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
+
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
+- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index a45a271322..545d546964 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -139,6 +139,45 @@ You can find more developers' resources in [`dev/`](dev) directory.
committer that merges your change will rebase and squash it into a single commit before
committing it to master.
+## Release notes
+
+Release notes are the way that Druid users will learn about your fix or improvement. What does a user need to know? The key is to identify the user impact. Give it your best shot! Druid committers will review and edit your notes.
+
+Here's a non-exhaustive list of the type of changes that have user impact and need release notes:
+
+* Changes what the user sees in the UI.
+* Changes any action that the user takes (in the UI, in the API, in configuration, in install, etc.)
+* Changes the results of any query, ingestion, or task.
+* Changes performance (preferably making things faster).
+* Adds, deprecates, or removes features.
+* Anything that changes install, configuration, or operation of Druid.
+
+An example of a change that doesn't need a release note is fixing a flakey test.
+
+Use these tips when writing your release note:
+
+**Summarize your change.** Describe the user impacting parts of your change, but try to be as concise as you can.
+
+**Be accurate, clear, and concise.** If you can't tick all of these off, the order of priority is accurate > clear > concise.
+
+**WIIFM - what's in it for me?** Spell out why the user should care. A release note shouldn't be like a stand-up update that focuses on the details of code changes.
+
+**Give enough context.** Make sure there's enough detail for users to do something with the information if they need to. For example, include the property they need to set and link to the documentation when possible.
+
+**You don't need to be formal and impersonal.** Speak directly to the user ("You can..."). Avoid passive voice (“X has been added”).
+
+### Example release notes
+
+| Template | Examples |
+|-------------------------------------------------|----------|
+| New: You can now… | New: You can now upload CSV files with a single header row for batch ingestion. Set the `infrerSchemaFromHeader` property of your ingestion spec to `true` to enable this feature. For more information, see [TITLE](/path/to/doc-file.md#anchor).|
+| Fixed: X no longer does Y when Z. | Fixed: Multi-value string array expressions no longer give flattened results when used in groupBy queries. |
+| Changed: X now does Y. Previously, X did Z. | Changed: The first/last string aggregator now only compares based on values. Previously, the first/last string aggregator’s values were compared based on the `_time` column first and then on values. |
+| Improved: Better / Increased / Updated etc. | Improved: You can now perform Kinesis ingestion even if there are empty shards. Previously, all shards had to have at least one record. |
+| Improved: Better / Increased / Updated etc. | Improved: Java 11 is fully supported and is no longer experimental. Java 17 support is improved. |
+| Deprecated: Removed / Will remove X. | Deprecated: Support for ZooKeeper X.Y will be removed in the next release, so consider upgrading ZooKeeper. For information about how to upgrade ZooKeeper, see the ZooKeeper documentation. |
+
+
## FAQ
### Help! I merged changes from upstream and cannot figure out how to resolve conflicts when rebasing!
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org