You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2017/05/15 22:47:48 UTC
Review Request 59290: Added '/log/network_size' metric.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59290/
-----------------------------------------------------------
Review request for mesos, Anindya Sinha and Benjamin Mahler.
Bugs: MESOS-7507
https://issues.apache.org/jira/browse/MESOS-7507
Repository: mesos
Description
-------
Added '<prefix>/log/network_size' metric.
Will update monitoring.md next.
Diffs
-----
src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4
src/log/metrics.hpp PRE-CREATION
src/log/metrics.cpp PRE-CREATION
src/tests/log_tests.cpp 52b1bfedd8d3f8f2ab3308c4be9f167126ee694b
Diff: https://reviews.apache.org/r/59290/diff/1/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 59290: Added '/log/network_size' metric.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59290/#review175143
-----------------------------------------------------------
Ship it!
Ship It!
- Anindya Sinha
On May 15, 2017, 10:47 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59290/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:47 p.m.)
>
>
> Review request for mesos, Anindya Sinha and Benjamin Mahler.
>
>
> Bugs: MESOS-7507
> https://issues.apache.org/jira/browse/MESOS-7507
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added '<prefix>/log/network_size' metric.
>
> Will update monitoring.md next.
>
>
> Diffs
> -----
>
> src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4
> src/log/metrics.hpp PRE-CREATION
> src/log/metrics.cpp PRE-CREATION
> src/tests/log_tests.cpp 52b1bfedd8d3f8f2ab3308c4be9f167126ee694b
>
>
> Diff: https://reviews.apache.org/r/59290/diff/1/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 59290: Added 'registrar/log/ensemble_size' metric.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59290/
-----------------------------------------------------------
(Updated May 16, 2017, 6:02 p.m.)
Review request for mesos, Anindya Sinha and Benjamin Mahler.
Changes
-------
Changed to a more descriptive name. NNFR.
Summary (updated)
-----------------
Added 'registrar/log/ensemble_size' metric.
Bugs: MESOS-7507
https://issues.apache.org/jira/browse/MESOS-7507
Repository: mesos
Description (updated)
-------
Added 'registrar/log/ensemble_size' metric.
Will update monitoring.md next.
Diffs (updated)
-----
src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4
src/log/metrics.hpp PRE-CREATION
src/log/metrics.cpp PRE-CREATION
src/tests/log_tests.cpp 52b1bfedd8d3f8f2ab3308c4be9f167126ee694b
Diff: https://reviews.apache.org/r/59290/diff/2/
Changes: https://reviews.apache.org/r/59290/diff/1-2/
Testing
-------
make check.
Thanks,
Jiang Yan Xu