You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "brancz (via GitHub)" <gi...@apache.org> on 2026/01/14 13:54:15 UTC

[PR] arrow-cast: Add display formatter for ListView [arrow-rs]

brancz opened a new pull request, #9175:
URL: https://github.com/apache/arrow-rs/pull/9175

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
   -->
   
   Closes https://github.com/apache/arrow-rs/issues/9173
   
   # Are these changes tested?
   
   I didn't add unit tests since the other formatters don't appear to be unit tested either, is the idea to test these via sql logic tests in df?
   
   # Are there any user-facing changes?
   
   No, just additive functionality
   
   @alamb @Jefffrey 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arrow-cast: Add display formatter for ListView [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9175:
URL: https://github.com/apache/arrow-rs/pull/9175#issuecomment-3756015791

   Thanks @Jefffrey and @brancz 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arrow-cast: Add display formatter for ListView [arrow-rs]

Posted by "brancz (via GitHub)" <gi...@apache.org>.
brancz commented on PR #9175:
URL: https://github.com/apache/arrow-rs/pull/9175#issuecomment-3749842079

   Clippy failures seem unrelated; that code wasn't touched in this patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arrow-cast: Add display formatter for ListView [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #9175:
URL: https://github.com/apache/arrow-rs/pull/9175


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arrow-cast: Add display formatter for ListView [arrow-rs]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #9175:
URL: https://github.com/apache/arrow-rs/pull/9175#issuecomment-3750116814

   > I didn't add unit tests since the other formatters don't appear to be unit tested either, is the idea to test these via sql logic tests in df?
   
   I think it would be good to add a test case somewhere, even if we didn't have any for the others.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org