You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@yetus.apache.org by "Allen Wittenauer (JIRA)" <ji...@apache.org> on 2019/05/02 20:43:00 UTC
[jira] [Comment Edited] (YETUS-868) Patch modifying the excludes
file should force a re-read
[ https://issues.apache.org/jira/browse/YETUS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831947#comment-16831947 ]
Allen Wittenauer edited comment on YETUS-868 at 5/2/19 8:42 PM:
----------------------------------------------------------------
-01:
* compute_gitdiff modified to handle the situation where there are no files left because the patch had all of the files excluded
* removal of leading ./ in various locations
* now have a baked in assumption that a relative path of the excludes file may be relative to BASEDIR (a few other params should probably have similar assumptions coded
* changes to various linecomments routines in case the gitunidifflines report didn't get generated in the no-files-left case
was (Author: aw):
-01:
* compute_gitdiff modified to handle the situation where there are no files left because the patch had all of the files excluded
* removal of leading ./ in various locations
* now have a baked in assumption that a relative path of the excludes file may be relative to BASEDIR (a few other params should probably have similar assumptions coded
* changes to various linecomments routines in case the gitunidifflines report didn't get generated in the no-files-left case
*
> Patch modifying the excludes file should force a re-read
> --------------------------------------------------------
>
> Key: YETUS-868
> URL: https://issues.apache.org/jira/browse/YETUS-868
> Project: Yetus
> Issue Type: Bug
> Components: Precommit
> Affects Versions: 0.10.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Critical
> Fix For: 0.11.0
>
> Attachments: YETUS-868.00.patch, YETUS-868.01.patch
>
>
> If a patch modifies the file that holds the exclusion data, it should get re-read and re-processed after it has been applied. Currently, it is only read at launch during determine_needed_tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)