[jira] [Commented] (CB-7457) cordova plugin add --searchpath does not recurse through subfolders when a plugin.xml is malformed in one of them

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-7457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120456#comment-14120456 ] 

ASF subversion and git services commented on CB-7457:
-----------------------------------------------------

Commit 61aee683e65e5382f75bd8304614d32574b5d918 in cordova-lib's branch refs/heads/master from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=61aee68 ]

CB-7457 - cordova plugin add --searchpath does not recurse through subfolders when a plugin.xml is malformed in one of them


> cordova plugin add --searchpath does not recurse through subfolders when a plugin.xml is malformed in one of them
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-7457
>                 URL: https://issues.apache.org/jira/browse/CB-7457
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI, CordovaLib, Plugman
>            Reporter: Shazron Abdullah
>             Fix For: 3.7.0
>
>
> This can be demonstrated by using the  createmobilespec.js script in cordova-mobile-spec or the repro steps below.
> Using local versions:
> cordova-cli from git: 3.6.0-0.2.10-dev
> cordova-plugman from git: 0.22.7-dev
> cordova-lib (linked locally - tagged at 7c0a701da98ebe89709cbaf97b3ca1535c6679b1)
> Repro steps:
> {code}
> $ cordova create Foo
> $ cd Foo
> $ cordova platform add ios
> $ cordova plugin add org.apache.cordova.device --searchpath /path/to/folder/containing/all/plugin-repos
> (where /path/to/folder/containing/all/plugin-repos is the mega folder containing all plugin git repos)
> {code}
> Error (essentially, plugin not found):
> {code}
> Calling plugman.fetch on plugin "org.apache.cordova.device"
> Error: Unencoded <
> Line: 105
> Column: 2
> Char: <
>     at error (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/elementtree/node_modules/sax/lib/sax.js:347:8)
>     at strictFail (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/elementtree/node_modules/sax/lib/sax.js:364:22)
>     at Object.write (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/elementtree/node_modules/sax/lib/sax.js:671:11)
>     at XMLParser.feed (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/elementtree/lib/parsers/sax.js:48:15)
>     at ElementTree.parse (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/elementtree/lib/elementtree.js:263:10)
>     at Object.exports.XML (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/node_modules/elementtree/lib/elementtree.js:593:13)
>     at Object.module.exports.parseElementtreeSync (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/src/util/xml-helpers.js:126:38)
>     at new PluginInfo (/Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/src/PluginInfo.js:213:37)
>     at /Users/shaz/Documents/Git/Apache/cordova-lib/cordova-lib/src/PluginInfo.js:275:17
>     at Array.forEach (native)
> {code}
> If I do --searchpath with the exact folder containing the plugin, it works.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)