You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/22 21:45:26 UTC

[GitHub] [incubator-tvm] comaniac edited a comment on issue #5410: [BYOC] Use Non-Recursive Visitor/Mutator

comaniac edited a comment on issue #5410:
URL: https://github.com/apache/incubator-tvm/pull/5410#issuecomment-618057145


   @mbrookhart I've fixed the unit tests which are related to the `AnnotateRegionSet`. Since `AnnotateRegionSet` was implemented using pre-order traversal (i.e., `process this node -> visit(node->args)`), I refactored its logic to post-order to fit to `MixedModeVisitor`. While passing all unit tests should guarantee its functionality, It'd be great if you could help checking if I miss-used `VisitExpr` in those passes. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org