[GitHub] [shardingsphere] sandynz commented on a diff in pull request #26616: Extract CDC build data node method

["sandynz (via GitHub)" <gi...@apache.org>]

sandynz commented on code in PR #26616:
URL: https://github.com/apache/shardingsphere/pull/26616#discussion_r1243383324


##########
test/e2e/operation/pipeline/src/test/java/org/apache/shardingsphere/test/e2e/data/pipeline/framework/helper/PipelineCaseHelper.java:
##########
@@ -85,7 +85,7 @@ public static List<Object[]> generateOrderInsertData(final DatabaseType database
                 int randomInt = generateInt(-100, 100);
                 Object orderId = keyGenerateAlgorithm.generateKey();
                 int randomUnsignedInt = generateInt(0, 100);
-                LocalDateTime now = LocalDateTime.now();
+                LocalDateTime now = LocalDateTime.now().withNano(0);

Review Comment:
   It's better to keep nano



##########
test/e2e/operation/pipeline/src/test/resources/env/scenario/general/mysql.xml:
##########
@@ -29,7 +29,7 @@
         `t_unsigned_tinyint` tinyint UNSIGNED NULL,
         `t_float` float NULL,
         `t_double` double NULL,
-        `t_decimal` decimal ( 10, 2 ) NULL,
+        `t_decimal` decimal ( 24, 10 ) NULL,

Review Comment:
   `decimal ( 10, 2 )` is widely used than `decimal ( 24, 10 )`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org