[GitHub] [spark] LuciferYang commented on a diff in pull request #41192: [SPARK-43530][PROTOBUF] Read descriptor file only once

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #41192:
URL: https://github.com/apache/spark/pull/41192#discussion_r1198789118


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/protobuf/functions.scala:
##########
@@ -45,12 +53,36 @@ object functions {
       messageName: String,
       descFilePath: String,
       options: java.util.Map[String, String]): Column = {
+    val binaryFileDescSet = readDescriptorFileContent(descFilePath)

Review Comment:
   Sorry for the late reply, will review this one later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org