[GitHub] xrmx commented on a change in pull request #3702: Add support for IE 11 for markup slices

[GitBox <gi...@apache.org>]

xrmx commented on a change in pull request #3702: Add support for IE 11 for markup slices
URL: https://github.com/apache/incubator-superset/pull/3702#discussion_r146259151
 
 

 ##########
 File path: superset/assets/visualizations/markup.js
 ##########
 @@ -23,9 +24,11 @@ function markupWidget(slice, payload) {
     <iframe id="${iframeId}"
       frameborder="0"
       height="${slice.height()}"
-      sandbox="allow-scripts">
+      sandbox="allow-same-origin allow-scripts allow-top-navigation allow-popups">
     </iframe>`);
-  $('#' + iframeId)[0].srcdoc = html;
+
+  const iframe = $('#' + iframeId)[0];
 
 Review comment:
   indentation is off and while we are at it we may just use a plain dom js function instead of jquery

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services