You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Avery Ching (JIRA)" <ji...@apache.org> on 2012/09/25 07:37:07 UTC
[jira] [Created] (GIRAPH-342) Recursive ZooKeeper calls should call
progress, dynamic ZooKeeper can skip delete
Avery Ching created GIRAPH-342:
----------------------------------
Summary: Recursive ZooKeeper calls should call progress, dynamic ZooKeeper can skip delete
Key: GIRAPH-342
URL: https://issues.apache.org/jira/browse/GIRAPH-342
Project: Giraph
Issue Type: Improvement
Reporter: Avery Ching
Assignee: Avery Ching
Sometimes a long running ZooKeeper deleteExt can take a while, causing a job to fail. This fixes that issue.
Additionally, this code has a minor optimization to not delete the ZooKeeper structure at the end of the application if it is a dynamically started ZooKeeper service.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-342) Recursive ZooKeeper calls should call
progress, dynamic ZooKeeper can skip delete
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-342:
-------------------------------
Attachment: GIRAPH-342.2.patch
Thanks for taking a look [~initialcontext]. This one is rebased.
> Recursive ZooKeeper calls should call progress, dynamic ZooKeeper can skip delete
> ---------------------------------------------------------------------------------
>
> Key: GIRAPH-342
> URL: https://issues.apache.org/jira/browse/GIRAPH-342
> Project: Giraph
> Issue Type: Improvement
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-342.2.patch, GIRAPH-342.patch
>
>
> Sometimes a long running ZooKeeper deleteExt can take a while, causing a job to fail. This fixes that issue.
> Additionally, this code has a minor optimization to not delete the ZooKeeper structure at the end of the application if it is a dynamically started ZooKeeper service.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-342) Recursive ZooKeeper calls should call
progress, dynamic ZooKeeper can skip delete
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-342:
-------------------------------
Attachment: GIRAPH-342.patch
This patch passes mvn clean verify
> Recursive ZooKeeper calls should call progress, dynamic ZooKeeper can skip delete
> ---------------------------------------------------------------------------------
>
> Key: GIRAPH-342
> URL: https://issues.apache.org/jira/browse/GIRAPH-342
> Project: Giraph
> Issue Type: Improvement
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-342.patch
>
>
> Sometimes a long running ZooKeeper deleteExt can take a while, causing a job to fail. This fixes that issue.
> Additionally, this code has a minor optimization to not delete the ZooKeeper structure at the end of the application if it is a dynamically started ZooKeeper service.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-342) Recursive ZooKeeper calls should
call progress, dynamic ZooKeeper can skip delete
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462460#comment-13462460 ]
Avery Ching commented on GIRAPH-342:
------------------------------------
https://reviews.apache.org/r/7245/
> Recursive ZooKeeper calls should call progress, dynamic ZooKeeper can skip delete
> ---------------------------------------------------------------------------------
>
> Key: GIRAPH-342
> URL: https://issues.apache.org/jira/browse/GIRAPH-342
> Project: Giraph
> Issue Type: Improvement
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-342.patch
>
>
> Sometimes a long running ZooKeeper deleteExt can take a while, causing a job to fail. This fixes that issue.
> Additionally, this code has a minor optimization to not delete the ZooKeeper structure at the end of the application if it is a dynamically started ZooKeeper service.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-342) Recursive ZooKeeper calls should
call progress, dynamic ZooKeeper can skip delete
Posted by "Maja Kabiljo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469030#comment-13469030 ]
Maja Kabiljo commented on GIRAPH-342:
-------------------------------------
+1, committing. Thanks, Avery.
> Recursive ZooKeeper calls should call progress, dynamic ZooKeeper can skip delete
> ---------------------------------------------------------------------------------
>
> Key: GIRAPH-342
> URL: https://issues.apache.org/jira/browse/GIRAPH-342
> Project: Giraph
> Issue Type: Improvement
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-342.2.patch, GIRAPH-342.patch
>
>
> Sometimes a long running ZooKeeper deleteExt can take a while, causing a job to fail. This fixes that issue.
> Additionally, this code has a minor optimization to not delete the ZooKeeper structure at the end of the application if it is a dynamically started ZooKeeper service.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-342) Recursive ZooKeeper calls should
call progress, dynamic ZooKeeper can skip delete
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464373#comment-13464373 ]
Eli Reisman commented on GIRAPH-342:
------------------------------------
This might be stale, I couldn't patch it into trunk today. Could be use of GiraphJob constants?
> Recursive ZooKeeper calls should call progress, dynamic ZooKeeper can skip delete
> ---------------------------------------------------------------------------------
>
> Key: GIRAPH-342
> URL: https://issues.apache.org/jira/browse/GIRAPH-342
> Project: Giraph
> Issue Type: Improvement
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-342.patch
>
>
> Sometimes a long running ZooKeeper deleteExt can take a while, causing a job to fail. This fixes that issue.
> Additionally, this code has a minor optimization to not delete the ZooKeeper structure at the end of the application if it is a dynamically started ZooKeeper service.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira