You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/14 17:18:28 UTC
[GitHub] [airflow] frankcash opened a new pull request, #25067: AIRFLOW-25062: changes for priority
frankcash opened a new pull request, #25067:
URL: https://github.com/apache/airflow/pull/25067
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] frankcash closed pull request #25067: AIRFLOW-25062: changes for priority
Posted by GitBox <gi...@apache.org>.
frankcash closed pull request #25067: AIRFLOW-25062: changes for priority
URL: https://github.com/apache/airflow/pull/25067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #25067: AIRFLOW-25062: changes for priority
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #25067:
URL: https://github.com/apache/airflow/pull/25067#discussion_r922285210
##########
airflow/www/static/js/graph.js:
##########
@@ -36,6 +36,7 @@ const dagRunId = getMetaValue('dag_run_id');
const arrange = getMetaValue('arrange');
const taskInstancesUrl = getMetaValue('task_instances_url');
const isSchedulerRunning = getMetaValue('is_scheduler_running');
+const priority = getMetaValue('priority');
Review Comment:
Unfortunately this won't work.
To use `getMetaValue()`, we need to add a `<meta>` tag in `graph.html`, but that really only works for simple types like strings
Instead, I'd follow the example of `tasks`, `nodes`, `edges` in `graph/html` and then add `priority` as one of the global declaration at the top of this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org