You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/08/07 05:00:47 UTC
[GitHub] [incubator-mxnet] kshitij12345 commented on a change in pull
request #15772: Add symbol api for randn and fix shape issue for randn
ndarray and symbol api
kshitij12345 commented on a change in pull request #15772: Add symbol api for randn and fix shape issue for randn ndarray and symbol api
URL: https://github.com/apache/incubator-mxnet/pull/15772#discussion_r311369085
##########
File path: python/mxnet/ndarray/random.py
##########
@@ -220,8 +220,6 @@ def randn(*shape, **kwargs):
dtype = kwargs.pop('dtype', _Null)
ctx = kwargs.pop('ctx', None)
out = kwargs.pop('out', None)
- assert isinstance(loc, (int, float))
Review comment:
I guess instead of removing this line it should be
```python
assert isinstance(loc, (int, float, NDArray)) # Whatever the exact type of NDArray is.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services