You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/03 07:34:16 UTC

[GitHub] [iceberg] kbendick commented on a diff in pull request #4670: Flink: add job level upsert config for table sink

kbendick commented on code in PR #4670:
URL: https://github.com/apache/iceberg/pull/4670#discussion_r863534591


##########
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/TestChangeLogTable.java:
##########
@@ -24,6 +24,7 @@
 import java.util.List;
 import org.apache.flink.types.Row;
 import org.apache.hadoop.conf.Configuration;
+import org.apache.iceberg.AssertHelpers;

Review Comment:
   I'd be fine with not adding for 1.13 in this PR (and backporting it once review is done).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org