You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by gi...@git.apache.org on 2017/08/23 14:07:19 UTC
[GitHub] eiri opened a new pull request #771: Fix chttpd's tests warnings
eiri opened a new pull request #771: Fix chttpd's tests warnings
URL: https://github.com/apache/couchdb/pull/771
## Overview
Some tests in `chttpd_db_doc_size_tests` and `chttpd_open_revs_error_test` specified incorrectly leading to actual assertions not to be run and the tests throwing warning on first compilation.
This change fixes those tests and doing some general house cleaning.
## Testing recommendations
On `make clean; make eunit apps=chttpd` no warnings should be printed and all the tests should pass.
Before:
```bash
$ make clean
$ make eunit apps=chttpd suites=chttpd_db_doc_size_tests
...
Compiled test/chttpd_db_test.erl
/home/vagrant/git/couchdb/src/chttpd/test/chttpd_db_doc_size_tests.erl:49: Warning: variable 'Else' is unused
/home/vagrant/git/couchdb/src/chttpd/test/chttpd_db_doc_size_tests.erl:121: Warning: a term is constructed, but never used
/home/vagrant/git/couchdb/src/chttpd/test/chttpd_db_doc_size_tests.erl:125: Warning: a term is constructed, but never used
/home/vagrant/git/couchdb/src/chttpd/test/chttpd_db_doc_size_tests.erl:130: Warning: a term is constructed, but never used
/home/vagrant/git/couchdb/src/chttpd/test/chttpd_db_doc_size_tests.erl:151: Warning: a term is constructed, but never used
/home/vagrant/git/couchdb/src/chttpd/test/chttpd_db_doc_size_tests.erl:174: Warning: a term is constructed, but never used.
...
```
## Checklist
- [x] Code is written and works correctly;
- [x] Changes are covered by tests;
- [ ] Documentation reflects the changes;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services