You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/03/07 22:07:36 UTC

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7382: Fix Internal Server Error when a Delivery Service's orgServerFqdn is an empty string, in some situations

codecov[bot] commented on PR #7382:
URL: https://github.com/apache/trafficcontrol/pull/7382#issuecomment-1458939841

   # [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7382?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#7382](https://codecov.io/gh/apache/trafficcontrol/pull/7382?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ac2281f) into [master](https://codecov.io/gh/apache/trafficcontrol/commit/b8159abbc028de0cf5e4a233e5f5c1e926e09a1e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8159ab) will **increase** coverage by `6.43%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #7382      +/-   ##
   ============================================
   + Coverage     26.12%   32.56%   +6.43%     
     Complexity       98       98              
   ============================================
     Files           648      460     -188     
     Lines         76280    38077   -38203     
     Branches         90       90              
   ============================================
   - Hits          19925    12398    -7527     
   + Misses        54520    24519   -30001     
   + Partials       1835     1160     -675     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | golib_unit | `52.47% <ø> (ø)` | |
   | grove_unit | `4.60% <ø> (ø)` | |
   | t3c_unit | `5.33% <ø> (ø)` | |
   | traffic_monitor_unit | `20.43% <ø> (ø)` | |
   | traffic_ops_unit | `?` | |
   | traffic_stats_unit | `10.14% <ø> (ø)` | |
   | unit_tests | `26.02% <ø> (+3.46%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/trafficcontrol/pull/7382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...fic\_ops\_golang/deliveryservice/deliveryservices.go](https://codecov.io/gh/apache/trafficcontrol/pull/7382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL2RlbGl2ZXJ5c2VydmljZS9kZWxpdmVyeXNlcnZpY2VzLmdv) | | |
   | [...affic\_ops/traffic\_ops\_golang/plugin/hello\_world.go](https://codecov.io/gh/apache/trafficcontrol/pull/7382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3BsdWdpbi9oZWxsb193b3JsZC5nbw==) | | |
   | [...affic\_ops/traffic\_ops\_golang/crstats/cdnrouting.go](https://codecov.io/gh/apache/trafficcontrol/pull/7382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL2Nyc3RhdHMvY2Rucm91dGluZy5nbw==) | | |
   | [...c\_ops\_golang/trafficvault/backends/riaksvc/riak.go](https://codecov.io/gh/apache/trafficcontrol/pull/7382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3RyYWZmaWN2YXVsdC9iYWNrZW5kcy9yaWFrc3ZjL3JpYWsuZ28=) | | |
   | [...ffic\_ops/traffic\_ops\_golang/server/queue\_update.go](https://codecov.io/gh/apache/trafficcontrol/pull/7382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3NlcnZlci9xdWV1ZV91cGRhdGUuZ28=) | | |
   | [...\_ops/traffic\_ops\_golang/deliveryservice/gencert.go](https://codecov.io/gh/apache/trafficcontrol/pull/7382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL2RlbGl2ZXJ5c2VydmljZS9nZW5jZXJ0Lmdv) | | |
   | [...affic\_ops\_golang/deliveryservice/servers/delete.go](https://codecov.io/gh/apache/trafficcontrol/pull/7382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL2RlbGl2ZXJ5c2VydmljZS9zZXJ2ZXJzL2RlbGV0ZS5nbw==) | | |
   | [...ic\_ops/traffic\_ops\_golang/topology/queue\_update.go](https://codecov.io/gh/apache/trafficcontrol/pull/7382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3RvcG9sb2d5L3F1ZXVlX3VwZGF0ZS5nbw==) | | |
   | [.../traffic\_ops\_golang/physlocation/phys\_locations.go](https://codecov.io/gh/apache/trafficcontrol/pull/7382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3BoeXNsb2NhdGlvbi9waHlzX2xvY2F0aW9ucy5nbw==) | | |
   | [...raffic\_ops/traffic\_ops\_golang/trafficstats/util.go](https://codecov.io/gh/apache/trafficcontrol/pull/7382?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhZmZpY19vcHMvdHJhZmZpY19vcHNfZ29sYW5nL3RyYWZmaWNzdGF0cy91dGlsLmdv) | | |
   | ... and [178 more](https://codecov.io/gh/apache/trafficcontrol/pull/7382?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org