You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/01/29 13:22:52 UTC
[GitHub] [druid] leventov opened a new issue #9284: FileRequestLogger is
prone to clock drift
leventov opened a new issue #9284: FileRequestLogger is prone to clock drift
URL: https://github.com/apache/druid/issues/9284
[`FileRequestLogger`](https://github.com/apache/druid/blob/master/server/src/main/java/org/apache/druid/server/log/FileRequestLogger.java) must not be provided with `ScheduledThreadPoolExecutor` to rotate request file logs and increment `currentDay`:
https://github.com/apache/druid/blob/6ee0afa8e5cdfd36409ef78b236bba085c40c892/server/src/main/java/org/apache/druid/server/log/FileRequestLogger.java#L84-L108
Because `ScheduledThreadPoolExecutor` is prone to [unbounded clock drift](https://medium.com/@leventov/cronscheduler-a-reliable-java-scheduler-for-external-interactions-cb7ce4a4f2cd).
[CronScheduler](https://github.com/TimeAndSpaceIO/CronScheduler) could be used instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhipatwari commented on issue #9284: FileRequestLogger is
prone to clock drift
Posted by GitBox <gi...@apache.org>.
abhipatwari commented on issue #9284: FileRequestLogger is prone to clock drift
URL: https://github.com/apache/druid/issues/9284#issuecomment-611509654
I'd like to contribute to this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org