You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/12/16 07:08:45 UTC

[GitHub] [tomcat] lanicc opened a new pull request #389: Optimize if condition

lanicc opened a new pull request #389:
URL: https://github.com/apache/tomcat/pull/389


   Optimize if condition in `AbstractProtocol.startAsyncTimeout()`,
   from `if (timeoutFuture == null || (timeoutFuture != null && timeoutFuture.isDone()))`
    to `if (timeoutFuture == null || timeoutFuture.isDone())`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] lanicc closed pull request #389: Optimize if condition

Posted by GitBox <gi...@apache.org>.
lanicc closed pull request #389:
URL: https://github.com/apache/tomcat/pull/389


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] martin-g commented on pull request #389: Optimize if condition

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #389:
URL: https://github.com/apache/tomcat/pull/389#issuecomment-745849044


   @lanicc Thanks for the PR! 
   Can you please remove the merge commit ? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] lanicc commented on pull request #389: Optimize if condition

Posted by GitBox <gi...@apache.org>.
lanicc commented on pull request #389:
URL: https://github.com/apache/tomcat/pull/389#issuecomment-745871337


   > @lanicc Thanks for the PR!
   > Can you please remove the merge commit ?
   
   ok, I will pull a new request


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org