You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/03 00:25:58 UTC

[jira] [Commented] (MINIFI-171) Dynamic Properties support for processors

    [ https://issues.apache.org/jira/browse/MINIFI-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15793759#comment-15793759 ] 

ASF GitHub Bot commented on MINIFI-171:
---------------------------------------

GitHub user jdye64 opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/37

    MINIFI-171  Dynamic Properties support for processors

    Added support in Processor.cpp to both set and get dynamic properties.
    The logic will first attempt to set the parsed Property from the .yml
    file as a supported property. IF that parsed Property is not in the
    whitelisted supported list AND if the “nifi.accept.dynamic.properties”
    configuration is set to true then the Property will be added to a
    Map<String, Property> of dynamic properties that can be accessed in a
    manner similar to the supported properties from any processor logic
    that extends Processor.cpp

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdye64/nifi-minifi-cpp MINIFI-171

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
    
----
commit 1d930fc3b9f3b228c567cc99b6d5617769491267
Author: Jeremy Dyer <jd...@gmail.com>
Date:   2017-01-03T00:24:37Z

    MINIFI-171  Dynamic Properties support for processors
    
    Added support in Processor.cpp to both set and get dynamic properties.
    The logic will first attempt to set the parsed Property from the .yml
    file as a supported property. IF that parsed Property is not in the
    whitelisted supported list AND if the “nifi.accept.dynamic.properties”
    configuration is set to true then the Property will be added to a
    Map<String, Property> of dynamic properties that can be accessed in a
    manner similar to the supported properties from any processor logic
    that extends Processor.cpp

----


> Dynamic Properties support for processors
> -----------------------------------------
>
>                 Key: MINIFI-171
>                 URL: https://issues.apache.org/jira/browse/MINIFI-171
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: cpp-0.1.0
>            Reporter: Jeremy Dyer
>            Assignee: Jeremy Dyer
>             Fix For: cpp-0.2.0
>
>
> Currently any Property read from the config.yml file that is not explicitly defined in the processor's implementation will be ignored by Processor.cpp when reading the configurations. This prevents any dynamic property from being defined in the config.yml and passed to the processor at runtime. Certain processors rely heavily on the concept of dynamic properties that are passed to them at runtime to handle things like setting dynamic properties based on properties that are declared. All of these possibilities cannot be handled upfront so there should be a mechanism, most likely in Processor.cpp, that allows for a list of dynamicProperties that are parsed form the config.yml file to be stored and accessed by the underlying processor implementation at runtime and use them as the processor desires.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)