You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/05/07 14:24:00 UTC
[kudu-CR] [java] Fix TestNegotiator on Java 9+
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10323
Change subject: [java] Fix TestNegotiator on Java 9+
......................................................................
[java] Fix TestNegotiator on Java 9+
TestNegotiator tests fail with a
java.nio.ReadOnlyBufferException when run on
Java 9+.
This patch creates a mutable ByteBuffer instead
to avoid the issue.
Change-Id: I6fd5bdf13b8b18caef2f8593a3c06512e4f7a0c5
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/10323/1
--
To view, visit http://gerrit.cloudera.org:8080/10323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6fd5bdf13b8b18caef2f8593a3c06512e4f7a0c5
Gerrit-Change-Number: 10323
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [java] Fix TestNegotiator on Java 9+
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10323 )
Change subject: [java] Fix TestNegotiator on Java 9+
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fd5bdf13b8b18caef2f8593a3c06512e4f7a0c5
Gerrit-Change-Number: 10323
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 07 May 2018 16:05:58 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Fix TestNegotiator on Java 9+
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10323 )
Change subject: [java] Fix TestNegotiator on Java 9+
......................................................................
[java] Fix TestNegotiator on Java 9+
TestNegotiator tests fail with a
java.nio.ReadOnlyBufferException when run on
Java 9+.
This patch creates a mutable ByteBuffer instead
to avoid the issue.
Change-Id: I6fd5bdf13b8b18caef2f8593a3c06512e4f7a0c5
Reviewed-on: http://gerrit.cloudera.org:8080/10323
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fd5bdf13b8b18caef2f8593a3c06512e4f7a0c5
Gerrit-Change-Number: 10323
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Fix TestNegotiator on Java 9+
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [java] Fix TestNegotiator on Java 9+
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I6fd5bdf13b8b18caef2f8593a3c06512e4f7a0c5
Gerrit-Change-Number: 10323
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Fix TestNegotiator on Java 9+
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10323 )
Change subject: [java] Fix TestNegotiator on Java 9+
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fd5bdf13b8b18caef2f8593a3c06512e4f7a0c5
Gerrit-Change-Number: 10323
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 07 May 2018 15:48:11 +0000
Gerrit-HasComments: No