You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/14 23:27:31 UTC
[GitHub] [superset] hughhhh opened a new pull request #12529: Update SqlEditor.jsx
hughhhh opened a new pull request #12529:
URL: https://github.com/apache/superset/pull/12529
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-764181256
Shall we close this?
@yousoph what do you think of Mode's solution?
I don't see the extra value of a dropdown other than looking prettier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #12529:
URL: https://github.com/apache/superset/pull/12529#discussion_r557777589
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -539,7 +539,15 @@ class SqlEditor extends React.PureComponent {
}
renderQueryLimit() {
- const menuDropdown = (
+ // Update the limit dropdown with SQL_ROW_MAX value
+ const { maxRow } = this.props;
+ let currentLimit = LIMIT_DROPDOWN[LIMIT_DROPDOWN.length - 1];
+ while (currentLimit < maxRow) {
+ currentLimit *= 10;
+ LIMIT_DROPDOWN.push(currentLimit);
Review comment:
what if the limit is 999999... should we do `10 000` and then `999 999`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-760553834
> we'll only be supporting multiples of 10
What's the benefit of this other than making the dropdown look prettier?
If the Superset admins think this is important, they should enforce this themselves.
My concerns is if the admin set the config value to `500,000`, but users are able to select `1,000,000`, it may cause confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-760545668
# [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=h1) Report
> Merging [#12529](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=desc) (fea9b34) into [master](https://codecov.io/gh/apache/superset/commit/3f3a2ad7ccdb299016ec4f04fa1b8d2075136607?el=desc) (3f3a2ad) will **decrease** coverage by `7.70%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12529 +/- ##
==========================================
- Coverage 66.72% 59.02% -7.71%
==========================================
Files 1014 958 -56
Lines 49612 46852 -2760
Branches 4839 4353 -486
==========================================
- Hits 33106 27656 -5450
- Misses 16383 19196 +2813
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.60% <66.66%> (-0.38%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.78% <ø> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.95% <66.66%> (-1.92%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `8.00% <0.00%> (-84.00%)` | :arrow_down: |
| ... and [384 more](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=footer). Last update [3f3a2ad...fea9b34](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-764181256
Shall we close this?
@yousoph what do you think of Mode's solution?
I don't see the extra value of a dropdown other than looking prettier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-760545668
# [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=h1) Report
> Merging [#12529](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=desc) (fea9b34) into [master](https://codecov.io/gh/apache/superset/commit/3f3a2ad7ccdb299016ec4f04fa1b8d2075136607?el=desc) (3f3a2ad) will **decrease** coverage by `3.38%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12529 +/- ##
==========================================
- Coverage 66.72% 63.34% -3.39%
==========================================
Files 1014 485 -529
Lines 49612 29946 -19666
Branches 4839 0 -4839
==========================================
- Hits 33106 18969 -14137
+ Misses 16383 10977 -5406
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.34% <ø> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.45% <0.00%> (-0.14%)` | :arrow_down: |
| [...frontend/src/SqlLab/components/QueryStateLabel.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U3RhdGVMYWJlbC5qc3g=) | | |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | | |
| ... and [526 more](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=footer). Last update [3f3a2ad...fea9b34](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh closed pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
hughhhh closed pull request #12529:
URL: https://github.com/apache/superset/pull/12529
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-760545668
# [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=h1) Report
> Merging [#12529](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=desc) (fea9b34) into [master](https://codecov.io/gh/apache/superset/commit/3f3a2ad7ccdb299016ec4f04fa1b8d2075136607?el=desc) (3f3a2ad) will **decrease** coverage by `2.94%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12529 +/- ##
==========================================
- Coverage 66.72% 63.78% -2.95%
==========================================
Files 1014 485 -529
Lines 49612 29946 -19666
Branches 4839 0 -4839
==========================================
- Hits 33106 19101 -14005
+ Misses 16383 10845 -5538
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.78% <ø> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | | |
| [superset-frontend/src/logger/LogUtils.ts](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9Mb2dVdGlscy50cw==) | | |
| [superset-frontend/src/components/DeleteModal.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGVsZXRlTW9kYWwudHN4) | | |
| [...end/src/visualizations/TimeTable/SparklineCell.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9TcGFya2xpbmVDZWxsLmpzeA==) | | |
| [...c/components/ListViewCard/ListViewCard.stories.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0xpc3RWaWV3Q2FyZC5zdG9yaWVzLnRzeA==) | | |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | | |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | | |
| [superset-frontend/src/utils/common.js](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvbW1vbi5qcw==) | | |
| ... and [520 more](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=footer). Last update [3f3a2ad...fea9b34](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-760545668
# [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=h1) Report
> Merging [#12529](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=desc) (fea9b34) into [master](https://codecov.io/gh/apache/superset/commit/3f3a2ad7ccdb299016ec4f04fa1b8d2075136607?el=desc) (3f3a2ad) will **decrease** coverage by `7.56%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12529 +/- ##
==========================================
- Coverage 66.72% 59.16% -7.57%
==========================================
Files 1014 958 -56
Lines 49612 46852 -2760
Branches 4839 4353 -486
==========================================
- Hits 33106 27720 -5386
- Misses 16383 19132 +2749
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <66.66%> (-0.01%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.78% <ø> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.95% <66.66%> (-1.92%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `8.00% <0.00%> (-84.00%)` | :arrow_down: |
| ... and [384 more](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=footer). Last update [3f3a2ad...fea9b34](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-760545668
# [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=h1) Report
> Merging [#12529](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=desc) (fea9b34) into [master](https://codecov.io/gh/apache/superset/commit/3f3a2ad7ccdb299016ec4f04fa1b8d2075136607?el=desc) (3f3a2ad) will **decrease** coverage by `3.38%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12529 +/- ##
==========================================
- Coverage 66.72% 63.34% -3.39%
==========================================
Files 1014 485 -529
Lines 49612 29946 -19666
Branches 4839 0 -4839
==========================================
- Hits 33106 18969 -14137
+ Misses 16383 10977 -5406
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.34% <ø> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.45% <0.00%> (-0.14%)` | :arrow_down: |
| [superset-frontend/src/messageToasts/types.ts](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvdHlwZXMudHM=) | | |
| [...dashboard/components/gridComponents/new/NewRow.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdSb3cuanN4) | | |
| ... and [526 more](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=footer). Last update [3f3a2ad...fea9b34](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-760545668
# [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=h1) Report
> Merging [#12529](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=desc) (fea9b34) into [master](https://codecov.io/gh/apache/superset/commit/3f3a2ad7ccdb299016ec4f04fa1b8d2075136607?el=desc) (3f3a2ad) will **decrease** coverage by `3.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12529 +/- ##
==========================================
- Coverage 66.72% 63.02% -3.71%
==========================================
Files 1014 485 -529
Lines 49612 29931 -19681
Branches 4839 0 -4839
==========================================
- Hits 33106 18864 -14242
+ Misses 16383 11067 -5316
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.02% <ø> (-0.90%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `93.40% <0.00%> (-6.05%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| ... and [548 more](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=footer). Last update [3f3a2ad...fea9b34](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-760545668
# [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=h1) Report
> Merging [#12529](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=desc) (fea9b34) into [master](https://codecov.io/gh/apache/superset/commit/3f3a2ad7ccdb299016ec4f04fa1b8d2075136607?el=desc) (3f3a2ad) will **decrease** coverage by `2.94%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12529 +/- ##
==========================================
- Coverage 66.72% 63.78% -2.95%
==========================================
Files 1014 485 -529
Lines 49612 29946 -19666
Branches 4839 0 -4839
==========================================
- Hits 33106 19101 -14005
+ Misses 16383 10845 -5538
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.78% <ø> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.37% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [...ntend/src/dashboard/util/backgroundStyleOptions.ts](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2JhY2tncm91bmRTdHlsZU9wdGlvbnMudHM=) | | |
| [superset-frontend/src/components/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3hJY29ucy50c3g=) | | |
| [superset-frontend/src/utils/parseCookie.ts](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3BhcnNlQ29va2llLnRz) | | |
| [...t-frontend/src/dashboard/reducers/dashboardInfo.js](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRJbmZvLmpz) | | |
| [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | | |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | | |
| [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | | |
| [...nd/src/dashboard/components/gridComponents/Row.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1Jvdy5qc3g=) | | |
| ... and [520 more](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=footer). Last update [3f3a2ad...fea9b34](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-760545668
# [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=h1) Report
> Merging [#12529](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=desc) (fea9b34) into [master](https://codecov.io/gh/apache/superset/commit/3f3a2ad7ccdb299016ec4f04fa1b8d2075136607?el=desc) (3f3a2ad) will **decrease** coverage by `3.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12529 +/- ##
==========================================
- Coverage 66.72% 63.39% -3.34%
==========================================
Files 1014 485 -529
Lines 49612 29946 -19666
Branches 4839 0 -4839
==========================================
- Hits 33106 18985 -14121
+ Misses 16383 10961 -5422
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.39% <ø> (-0.53%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [...-frontend/src/dashboard/util/getDragDropManager.js](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyYWdEcm9wTWFuYWdlci5qcw==) | | |
| [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | | |
| [...set-frontend/src/dashboard/util/getLocationHash.ts](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExvY2F0aW9uSGFzaC50cw==) | | |
| [.../src/dashboard/util/serializeActiveFilterValues.js](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUFjdGl2ZUZpbHRlclZhbHVlcy5qcw==) | | |
| [...nd/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYi5qc3g=) | | |
| ... and [523 more](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=footer). Last update [3f3a2ad...fea9b34](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michellethomas commented on a change in pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
michellethomas commented on a change in pull request #12529:
URL: https://github.com/apache/superset/pull/12529#discussion_r557797715
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -539,7 +539,15 @@ class SqlEditor extends React.PureComponent {
}
renderQueryLimit() {
- const menuDropdown = (
+ // Update the limit dropdown with SQL_ROW_MAX value
+ const { maxRow } = this.props;
Review comment:
It looks like this limit control is getting applied to the UI results and to CSV export. Our main concern is with CSV export so that's why I mentioned the `SQL_ROW_MAX`. If I run a query with a limit 10 in the UI dropdown (with no limit in the query) and run it then download csv I get only 10 rows in the CSV. It sounds like this is the same as the old functionality for the limit UI control to affect the csv and the UI results. I wasn't aware that changed, but if there's some other setting we need to make the UI limit only apply to the ui results let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #12529:
URL: https://github.com/apache/superset/pull/12529#discussion_r557777589
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -539,7 +539,15 @@ class SqlEditor extends React.PureComponent {
}
renderQueryLimit() {
- const menuDropdown = (
+ // Update the limit dropdown with SQL_ROW_MAX value
+ const { maxRow } = this.props;
+ let currentLimit = LIMIT_DROPDOWN[LIMIT_DROPDOWN.length - 1];
+ while (currentLimit < maxRow) {
+ currentLimit *= 10;
+ LIMIT_DROPDOWN.push(currentLimit);
Review comment:
what if the limit is 999999... should we do `100 000` and then `999 999`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12529:
URL: https://github.com/apache/superset/pull/12529#discussion_r557779442
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -539,7 +539,15 @@ class SqlEditor extends React.PureComponent {
}
renderQueryLimit() {
- const menuDropdown = (
+ // Update the limit dropdown with SQL_ROW_MAX value
+ const { maxRow } = this.props;
Review comment:
This should be `DISPLAY_MAX_ROW`, not `SQL_ROW_MAX`. `SQL_MAX_ROW` is for results backend and CSV export.
Also, what happens if the user sets a `DEFAULT_SQLLAB_LIMIT` that's not a multiple of 10?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-760545668
# [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=h1) Report
> Merging [#12529](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=desc) (fea9b34) into [master](https://codecov.io/gh/apache/superset/commit/3f3a2ad7ccdb299016ec4f04fa1b8d2075136607?el=desc) (3f3a2ad) will **decrease** coverage by `3.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12529 +/- ##
==========================================
- Coverage 66.72% 63.02% -3.71%
==========================================
Files 1014 485 -529
Lines 49612 29931 -19681
Branches 4839 0 -4839
==========================================
- Hits 33106 18864 -14242
+ Misses 16383 11067 -5316
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.02% <ø> (-0.90%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `93.40% <0.00%> (-6.05%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| ... and [548 more](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=footer). Last update [3f3a2ad...fea9b34](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
yousoph commented on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-764881878
Yes, I think we can close this.
The thought with the dropdown was to make it easy to adjust to a few different orders of magnitude for the user to use, but given the feedback I'd like to revisit it and see if we need to simplify + add more flexibility to how users set the limit... while making sure it's still performant in the browser :)
(cc @steejay fyi)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-760553834
> we'll only be supporting multiples of 10
What's the benefit of this other than making the dropdown look prettier?
If the Superset admins think this is important, they should enforce this themselves.
My concerns is if the admin set the config value to `500,000`, but users are able to select 1000,000, it may cause confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-760577667
It seems to me the original intention of adding a limit input is for preventing users from accidentally running long queries (either for database or for displaying in SQL lab). If that's the case, why not simplify things and make it a default-selected checkbox of "Limit 100" [like Mode does](https://mode.com/sql-tutorial/sql-limit/)?
This also avoids the confusion whether the limit number applies to the CSV or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
yousoph commented on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-764881878
Yes, I think we can close this.
The thought with the dropdown was to make it easy to adjust to a few different orders of magnitude for the user to use, but given the feedback I'd like to revisit it and see if we need to simplify + add more flexibility to how users set the limit... while making sure it's still performant in the browser :)
(cc @steejay fyi)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #12529:
URL: https://github.com/apache/superset/pull/12529#discussion_r557777358
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -539,7 +539,15 @@ class SqlEditor extends React.PureComponent {
}
renderQueryLimit() {
- const menuDropdown = (
+ // Update the limit dropdown with SQL_ROW_MAX value
+ const { maxRow } = this.props;
Review comment:
to be safe, should we set a default if not defined?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-760545668
# [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=h1) Report
> Merging [#12529](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=desc) (fea9b34) into [master](https://codecov.io/gh/apache/superset/commit/3f3a2ad7ccdb299016ec4f04fa1b8d2075136607?el=desc) (3f3a2ad) will **decrease** coverage by `3.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12529 +/- ##
==========================================
- Coverage 66.72% 63.39% -3.34%
==========================================
Files 1014 485 -529
Lines 49612 29946 -19666
Branches 4839 0 -4839
==========================================
- Hits 33106 18985 -14121
+ Misses 16383 10961 -5422
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.39% <ø> (-0.53%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [...t-frontend/src/dashboard/util/setPeriodicRunner.ts](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NldFBlcmlvZGljUnVubmVyLnRz) | | |
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | | |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | | |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | | |
| [...et-frontend/src/components/ListView/ActionsBar.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQWN0aW9uc0Jhci50c3g=) | | |
| ... and [523 more](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=footer). Last update [3f3a2ad...fea9b34](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12529:
URL: https://github.com/apache/superset/pull/12529#issuecomment-760545668
# [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=h1) Report
> Merging [#12529](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=desc) (fea9b34) into [master](https://codecov.io/gh/apache/superset/commit/3f3a2ad7ccdb299016ec4f04fa1b8d2075136607?el=desc) (3f3a2ad) will **decrease** coverage by `3.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12529 +/- ##
==========================================
- Coverage 66.72% 63.39% -3.34%
==========================================
Files 1014 485 -529
Lines 49612 29946 -19666
Branches 4839 0 -4839
==========================================
- Hits 33106 18985 -14121
+ Misses 16383 10961 -5422
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.39% <ø> (-0.53%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [...d/src/filters/components/Range/AntdRangeFilter.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9BbnRkUmFuZ2VGaWx0ZXIudHN4) | | |
| [...erset-frontend/src/SqlLab/components/SaveQuery.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS50c3g=) | | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | | |
| [...d/src/dashboard/components/FiltersBadge/Styles.tsx](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9TdHlsZXMudHN4) | | |
| ... and [523 more](https://codecov.io/gh/apache/superset/pull/12529/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=footer). Last update [3f3a2ad...fea9b34](https://codecov.io/gh/apache/superset/pull/12529?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org