You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "erisu (via GitHub)" <gi...@apache.org> on 2023/04/13 10:17:46 UTC
[GitHub] [cordova-ios] erisu opened a new pull request, #1305: dep!: bump all possible dependencies
erisu opened a new pull request, #1305:
URL: https://github.com/apache/cordova-ios/pull/1305
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
n/a
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Use latest dependencies and remove any audit warnings in package-loc.json
### Description
<!-- Describe your changes in detail -->
Bumped:
- [dep: update semver@7.4.0](https://github.com/apache/cordova-ios/commit/2f6e254d9e812004a67b02a634577d9261e59785)
- [dep: update plist@3.0.6](https://github.com/apache/cordova-ios/commit/6e7035b7fc3ecfe9818e90059691d98bd77cc2ce)
- [dep!: update fs-extra@11.1.1](https://github.com/apache/cordova-ios/commit/97e3b58ec9224c020e7e071145b7ba34747d676b)
- [dep!: update cordova-common@5.0.0](https://github.com/apache/cordova-ios/commit/873bd3f77d171d6fb5e303307b43e7269bfcc9a4)
- [dep!: update nopt@7.1.0](https://github.com/apache/cordova-ios/commit/6e8b91b37f8b9f3c8fad8dff7818aa83ec05db3a)
- [dep!: update which@3.0.0](https://github.com/apache/cordova-ios/commit/b5a22e5e849f342a9ce55ae3aeafd3f7eb8a9fa6)
- [dep!: update @cordova/eslint-config@5.0.0](https://github.com/apache/cordova-ios/commit/99aee49221e33db93e6321a101eaaf92e4a60672)
- [dep!: update jasmine@4.6.0](https://github.com/apache/cordova-ios/commit/8f083590001e1a2e27ea51dfbdb0d2d585997ee7)
- [dep!: update rewire@6.0.0](https://github.com/apache/cordova-ios/commit/401a679bb3d46ad5ccbdf6a96307932abbcb379e)
Other:
- [feat!: bump node engine requirement >=16.13.0](https://github.com/apache/cordova-ios/commit/7b867acbcc47167f37597b947cf2744a904c55b7) to support requirements of `which` and `nopt`
- [dep: update xml-escape integrity value](https://github.com/apache/cordova-ios/commit/a1025f0868070ef7334a84121890bed48ca263ba)
- Rebuilt `package-lock`
### Testing
<!-- Please describe in detail how you tested your changes. -->
`npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] breautek commented on pull request #1305: dep!: bump all possible dependencies w/ node engine requirement update >=16.13.0
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #1305:
URL: https://github.com/apache/cordova-ios/pull/1305#issuecomment-1507007219
Was `package-lock` rebuilt?
If not we should run `npm upgrade` to force package-lock to update all of our subdependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] erisu commented on pull request #1305: dep!: bump all possible dependencies
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu commented on PR #1305:
URL: https://github.com/apache/cordova-ios/pull/1305#issuecomment-1507005169
@dpogue yes, you are correct. I have dropped Node 14.x from the CI. Because of the bumping of the packages that increased the node engine requirement, it should also include the CI changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter commented on pull request #1305: dep!: bump all possible dependencies
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1305:
URL: https://github.com/apache/cordova-ios/pull/1305#issuecomment-1506727328
## [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1305?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1305](https://codecov.io/gh/apache/cordova-ios/pull/1305?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (11e14e0) into [master](https://codecov.io/gh/apache/cordova-ios/commit/ad609240b8b780d2b3f971642e685e5b157029e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ad60924) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1305 +/- ##
=======================================
Coverage 78.25% 78.25%
=======================================
Files 15 15
Lines 1761 1761
=======================================
Hits 1378 1378
Misses 383 383
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] erisu merged pull request #1305: dep!: bump all possible dependencies w/ node engine requirement update >=16.13.0
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu merged PR #1305:
URL: https://github.com/apache/cordova-ios/pull/1305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue commented on pull request #1305: dep!: bump all possible dependencies
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on PR #1305:
URL: https://github.com/apache/cordova-ios/pull/1305#issuecomment-1506945506
We're still testing Node 14 in CI (and somehow it appears to be passing?)... presumably we should drop that if we're introducing a node 16.13.0 minimum?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org