You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@santuario.apache.org by bl...@apache.org on 2006/05/28 02:26:01 UTC
svn commit: r409897 - /xml/security/trunk/c/src/dsig/DSIGReference.cpp
Author: blautenb
Date: Sat May 27 17:26:00 2006
New Revision: 409897
URL: http://svn.apache.org/viewvc?rev=409897&view=rev
Log:
Reorder reference hash sequence as per suggestion by Peter Gubis on security-dev@xml.apache.org in April 2006
Modified:
xml/security/trunk/c/src/dsig/DSIGReference.cpp
Modified: xml/security/trunk/c/src/dsig/DSIGReference.cpp
URL: http://svn.apache.org/viewvc/xml/security/trunk/c/src/dsig/DSIGReference.cpp?rev=409897&r1=409896&r2=409897&view=diff
==============================================================================
--- xml/security/trunk/c/src/dsig/DSIGReference.cpp (original)
+++ xml/security/trunk/c/src/dsig/DSIGReference.cpp Sat May 27 17:26:00 2006
@@ -854,13 +854,16 @@
r = lst->item(j);
- r->setHash();
-
// If this is a manifest we need to set all the references in the manifest as well
if (r->isManifest())
hashReferenceList(r->getManifestReferenceList());
+
+ // Re-ordered as per suggestion by Peter Gubis to make it more likely
+ // that hashes are correct on first pass when manifests are involved
+ r->setHash();
+
}
} while (interlocking && !DSIGReference::verifyReferenceList(lst, errStr) && i-- >= 0);