You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Paul Fremantle <pz...@gmail.com> on 2008/10/01 14:17:22 UTC
Understanding the code repo situation with GitHub
Folks
Do we still have "active" code in GitHub? Can someone enlighten me as
to the situation?
Paul
--
Paul Fremantle
Co-Founder and CTO, WSO2
Apache Synapse PMC Chair
OASIS WS-RX TC Co-chair
blog: http://pzf.fremantle.org
paul@wso2.com
"Oxygenating the Web Service Platform", www.wso2.com
Re: Understanding the code repo situation with GitHub
Posted by Carl Trieloff <cc...@redhat.com>.
Paul Fremantle wrote:
> Folks
>
> Do we still have "active" code in GitHub? Can someone enlighten me as
> to the situation?
>
> Paul
>
>
It gets used to merge / test code better some of the committers, prior
to bringing it to trunk. I
know various people use GIT to manage work, and then merge back to trunk
once the pieces come
together. So I only know of trees that are used for working on a
specific features, like Steve is doing
with the Windows port.
The big one out there currently I believe is Steve's port with I believe
he is going to start merging, the
big RDMA tree has been merged.
reason for asking?
Carl.
Re: Understanding the code repo situation with GitHub
Posted by Paul Fremantle <pz...@gmail.com>.
>> Finally, I would be happier if there was a date by which the GitHub
>> code will be re-integrated into the SVN and our GitHub tree
>> decommissioned.
>
> It's in progress now. Hopefully within a couple of weeks that will be
> done.
Great thanks!
Paul
--
Paul Fremantle
Co-Founder and CTO, WSO2
Apache Synapse PMC Chair
OASIS WS-RX TC Co-chair
blog: http://pzf.fremantle.org
paul@wso2.com
"Oxygenating the Web Service Platform", www.wso2.com
Re: Understanding the code repo situation with GitHub
Posted by Aidan Skinner <ai...@apache.org>.
On Sat, Oct 4, 2008 at 7:57 AM, Paul Fremantle <pz...@gmail.com> wrote:
Which other projects are using Git?
>
Cocoon, buildr and shindig all have projects on github. There are others
hosted on different centralised services and some on personal servers.
- Aidan
--
Apache Qpid - World Domination through Advanced Message Queueing
http://cwiki.apache.org/qpid
"Nine-tenths of wisdom consists in being wise in time." - Theodore Roosevelt
Re: Understanding the code repo situation with GitHub
Posted by Paul Fremantle <pz...@gmail.com>.
> 3. Other Apache projects are using git quite happily and I'm not aware of
> any concerns being raised about it.
Aidan
Which other projects are using Git?
Paul
--
Paul Fremantle
Co-Founder and CTO, WSO2
Apache Synapse PMC Chair
OASIS WS-RX TC Co-chair
blog: http://pzf.fremantle.org
paul@wso2.com
"Oxygenating the Web Service Platform", www.wso2.com
Re: Understanding the code repo situation with GitHub
Posted by Paul Fremantle <pz...@gmail.com>.
Aidan
As long as each patch is submitted individually through JIRA, and the
person creating the patch is the person who wrote it, and they can
therefore click the checkbox that donates that code under the ASL
applies, then what you say is completely correct.
Maybe I misunderstood Steve's previous notes, but that is not the
impression I got.
Paul
On Thu, Oct 2, 2008 at 3:10 PM, Aidan Skinner <ai...@apache.org> wrote:
> On Thu, Oct 2, 2008 at 12:10 PM, Paul Fremantle <pz...@gmail.com> wrote:
>
>
>> Finally, I would be happier if there was a date by which the GitHub
>> code will be re-integrated into the SVN and our GitHub tree
>> decommissioned.
>>
>
> 1. Code from github should be integrated into our tree via the usual process
> - by attaching it to a Jira and having it reviewed by a committer.
>
> 2. I don't see the legal difference between code that has been stored in
> git, and code which has been stored on a contributors hard drive before it's
> been put through the proper process to get it into Apache SVN.
>
> 3. Other Apache projects are using git quite happily and I'm not aware of
> any concerns being raised about it.
>
> - Aidan
> --
> Apache Qpid - World Domination through Advanced Message Queueing
> http://cwiki.apache.org/qpid
> "Nine-tenths of wisdom consists in being wise in time." - Theodore Roosevelt
>
--
Paul Fremantle
Co-Founder and CTO, WSO2
Apache Synapse PMC Chair
OASIS WS-RX TC Co-chair
blog: http://pzf.fremantle.org
paul@wso2.com
"Oxygenating the Web Service Platform", www.wso2.com
Re: Understanding the code repo situation with GitHub
Posted by Aidan Skinner <ai...@apache.org>.
On Thu, Oct 2, 2008 at 12:10 PM, Paul Fremantle <pz...@gmail.com> wrote:
> Finally, I would be happier if there was a date by which the GitHub
> code will be re-integrated into the SVN and our GitHub tree
> decommissioned.
>
1. Code from github should be integrated into our tree via the usual process
- by attaching it to a Jira and having it reviewed by a committer.
2. I don't see the legal difference between code that has been stored in
git, and code which has been stored on a contributors hard drive before it's
been put through the proper process to get it into Apache SVN.
3. Other Apache projects are using git quite happily and I'm not aware of
any concerns being raised about it.
- Aidan
--
Apache Qpid - World Domination through Advanced Message Queueing
http://cwiki.apache.org/qpid
"Nine-tenths of wisdom consists in being wise in time." - Theodore Roosevelt
RE: Understanding the code repo situation with GitHub
Posted by Steve Huston <sh...@riverace.com>.
Hi Paul,
> I'm probably going to sound a little bit "arsy" as we say in
England.
> I don't mean to - I'm not criticizing what's happened, but as mentor
I
> need to make some points here.
No problem at all - I'm pleased to get the feedback. The projects I've
contributed to in the past played "fast and loose" with the code
contributions - the tightness around this area is one thing I
appreciate about Apache and I certainly don't want to go against that.
> 1) Having an Apache ICLA from people who contributed to GitHub does
> not count. The Apache ICLA makes statements about contributions to
> Apache. Code that is contributed to the Github is not covered. So
when
> you then contribute that code from GitHub into Apache then it is not
> covered. Looking back in the mailing list I see that you were poorly
> advised on this front. I apologize for not picking this up earlier
and
> not commenting at that time.
Ok... One problem feeding this issue is that my intro to contributing
to Qpid is a Windows port - not something easy to plop into a single
patch. Since I was hoping for assistance from others and couldn't
check into the Qpid svn repo, even on a branch, I had few options.
> 2) This is a subset of a wider problem. The management of IP within
> Apache is a huge part of the governance of code, and it cannot be
> bypassed without serious consequences. Having you decide if there is
> an ICLA in place and accepting code on that basis completely
bypasses
> the well documented Apache process that is the responsibility of the
> (I)PMC. Luckily the whole point of incubation is to learn these
> lessons, so at this stage this isn't serious. But on the other hand,
I
> can't leave this undiscussed either!
>
> 3) Its not your responsibility to decide whether contributions are
> significant or not. A significant contribution in one person's eyes
> might be insignificant in another's. The whole Apache project
started
> out from "a few bug fixes". Without seeing the patches go by, the
> community cannot judge the quality of contributions.
Point taken. Thanks.
> Finally, I would be happier if there was a date by which the GitHub
> code will be re-integrated into the SVN and our GitHub tree
> decommissioned.
It's in progress now. Hopefully within a couple of weeks that will be
done.
-Steve
Re: Understanding the code repo situation with GitHub
Posted by Paul Fremantle <pz...@gmail.com>.
Steve
I'm probably going to sound a little bit "arsy" as we say in England.
I don't mean to - I'm not criticizing what's happened, but as mentor I
need to make some points here.
1) Having an Apache ICLA from people who contributed to GitHub does
not count. The Apache ICLA makes statements about contributions to
Apache. Code that is contributed to the Github is not covered. So when
you then contribute that code from GitHub into Apache then it is not
covered. Looking back in the mailing list I see that you were poorly
advised on this front. I apologize for not picking this up earlier and
not commenting at that time.
2) This is a subset of a wider problem. The management of IP within
Apache is a huge part of the governance of code, and it cannot be
bypassed without serious consequences. Having you decide if there is
an ICLA in place and accepting code on that basis completely bypasses
the well documented Apache process that is the responsibility of the
(I)PMC. Luckily the whole point of incubation is to learn these
lessons, so at this stage this isn't serious. But on the other hand, I
can't leave this undiscussed either!
3) Its not your responsibility to decide whether contributions are
significant or not. A significant contribution in one person's eyes
might be insignificant in another's. The whole Apache project started
out from "a few bug fixes". Without seeing the patches go by, the
community cannot judge the quality of contributions.
Finally, I would be happier if there was a date by which the GitHub
code will be re-integrated into the SVN and our GitHub tree
decommissioned.
Paul
On Wed, Oct 1, 2008 at 5:48 PM, Steve Huston <sh...@riverace.com> wrote:
> Hi Paul,
>
> FYI on the committers... I'm intensely aware of the licensing and IP
> considerations. I didn't let anyone have write access to the github
> repo without an Apache ICLA on file. One person emailed me changes - I
> didn't read those until the ICLA was submitted.
>
> The code done by people other than me amounted to a few bug fixes.
> Useful, no doubt, but not new features.
>
> -Steve
>
>> -----Original Message-----
>> From: Paul Fremantle [mailto:pzfreo@gmail.com]
>> Sent: Wednesday, October 01, 2008 12:07 PM
>> To: qpid-dev@incubator.apache.org
>> Subject: Re: Understanding the code repo situation with GitHub
>>
>>
>> I think its important for graduation that all code is managed on the
>> Apache SVN. While I can see that the approach you took prior to
>> commitership was useful, it isn't a good model generally within
>> Apache. For example, if other non-committers or even committers did
>> contribute code to GitHub then the record of that will not propogate
>> into the SVN. Non-committers are explicitly encouraged to submit
>> patches, so the rest of the community gets to see the contributions,
>> and in this case that wouldn't have happened.
>>
>> I'm glad to hear it is being phased out.
>>
>> Thanks
>> Paul
>>
>> On Wed, Oct 1, 2008 at 3:32 PM, Steve Huston
>> <sh...@riverace.com> wrote:
>> > Hi Paul,
>> >
>> >> Do we still have "active" code in GitHub? Can someone enlighten
> me
>> > as
>> >> to the situation?
>> >
>> > Since I have a github repository related to Qpid, I'll
>> answer from my
>> > point of view.
>> >
>> > The qpid-port github repository I created was mainly driven
>> because I
>> > hoped to share this with other people interested in Windows and I
>> > didn't have subversion commit permission. Github was a suggested
>> > alternative.
>> >
>> > Now that I do have subversion commit permission, I'm unlikely to
>> > continue on github for qpid work. I'll be merging the Windows port
>> > changes back to subversion and the qpid-port github repository
> will
>> > not be actively maintained and may be removed.
>> >
>> > -Steve
>> >
>> >
>> >
>>
>>
>>
>> --
>> Paul Fremantle
>> Co-Founder and CTO, WSO2
>> Apache Synapse PMC Chair
>> OASIS WS-RX TC Co-chair
>>
>> blog: http://pzf.fremantle.org
>> paul@wso2.com
>>
>> "Oxygenating the Web Service Platform", www.wso2.com
>>
>
>
>
--
Paul Fremantle
Co-Founder and CTO, WSO2
Apache Synapse PMC Chair
OASIS WS-RX TC Co-chair
blog: http://pzf.fremantle.org
paul@wso2.com
"Oxygenating the Web Service Platform", www.wso2.com
RE: Understanding the code repo situation with GitHub
Posted by Steve Huston <sh...@riverace.com>.
Hi Paul,
FYI on the committers... I'm intensely aware of the licensing and IP
considerations. I didn't let anyone have write access to the github
repo without an Apache ICLA on file. One person emailed me changes - I
didn't read those until the ICLA was submitted.
The code done by people other than me amounted to a few bug fixes.
Useful, no doubt, but not new features.
-Steve
> -----Original Message-----
> From: Paul Fremantle [mailto:pzfreo@gmail.com]
> Sent: Wednesday, October 01, 2008 12:07 PM
> To: qpid-dev@incubator.apache.org
> Subject: Re: Understanding the code repo situation with GitHub
>
>
> I think its important for graduation that all code is managed on the
> Apache SVN. While I can see that the approach you took prior to
> commitership was useful, it isn't a good model generally within
> Apache. For example, if other non-committers or even committers did
> contribute code to GitHub then the record of that will not propogate
> into the SVN. Non-committers are explicitly encouraged to submit
> patches, so the rest of the community gets to see the contributions,
> and in this case that wouldn't have happened.
>
> I'm glad to hear it is being phased out.
>
> Thanks
> Paul
>
> On Wed, Oct 1, 2008 at 3:32 PM, Steve Huston
> <sh...@riverace.com> wrote:
> > Hi Paul,
> >
> >> Do we still have "active" code in GitHub? Can someone enlighten
me
> > as
> >> to the situation?
> >
> > Since I have a github repository related to Qpid, I'll
> answer from my
> > point of view.
> >
> > The qpid-port github repository I created was mainly driven
> because I
> > hoped to share this with other people interested in Windows and I
> > didn't have subversion commit permission. Github was a suggested
> > alternative.
> >
> > Now that I do have subversion commit permission, I'm unlikely to
> > continue on github for qpid work. I'll be merging the Windows port
> > changes back to subversion and the qpid-port github repository
will
> > not be actively maintained and may be removed.
> >
> > -Steve
> >
> >
> >
>
>
>
> --
> Paul Fremantle
> Co-Founder and CTO, WSO2
> Apache Synapse PMC Chair
> OASIS WS-RX TC Co-chair
>
> blog: http://pzf.fremantle.org
> paul@wso2.com
>
> "Oxygenating the Web Service Platform", www.wso2.com
>
Re: Understanding the code repo situation with GitHub
Posted by Paul Fremantle <pz...@gmail.com>.
I think its important for graduation that all code is managed on the
Apache SVN. While I can see that the approach you took prior to
commitership was useful, it isn't a good model generally within
Apache. For example, if other non-committers or even committers did
contribute code to GitHub then the record of that will not propogate
into the SVN. Non-committers are explicitly encouraged to submit
patches, so the rest of the community gets to see the contributions,
and in this case that wouldn't have happened.
I'm glad to hear it is being phased out.
Thanks
Paul
On Wed, Oct 1, 2008 at 3:32 PM, Steve Huston <sh...@riverace.com> wrote:
> Hi Paul,
>
>> Do we still have "active" code in GitHub? Can someone enlighten me
> as
>> to the situation?
>
> Since I have a github repository related to Qpid, I'll answer from my
> point of view.
>
> The qpid-port github repository I created was mainly driven because I
> hoped to share this with other people interested in Windows and I
> didn't have subversion commit permission. Github was a suggested
> alternative.
>
> Now that I do have subversion commit permission, I'm unlikely to
> continue on github for qpid work. I'll be merging the Windows port
> changes back to subversion and the qpid-port github repository will
> not be actively maintained and may be removed.
>
> -Steve
>
>
>
--
Paul Fremantle
Co-Founder and CTO, WSO2
Apache Synapse PMC Chair
OASIS WS-RX TC Co-chair
blog: http://pzf.fremantle.org
paul@wso2.com
"Oxygenating the Web Service Platform", www.wso2.com
RE: Understanding the code repo situation with GitHub
Posted by Steve Huston <sh...@riverace.com>.
Hi Paul,
> Do we still have "active" code in GitHub? Can someone enlighten me
as
> to the situation?
Since I have a github repository related to Qpid, I'll answer from my
point of view.
The qpid-port github repository I created was mainly driven because I
hoped to share this with other people interested in Windows and I
didn't have subversion commit permission. Github was a suggested
alternative.
Now that I do have subversion commit permission, I'm unlikely to
continue on github for qpid work. I'll be merging the Windows port
changes back to subversion and the qpid-port github repository will
not be actively maintained and may be removed.
-Steve