You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ajantha-bhat (via GitHub)" <gi...@apache.org> on 2023/04/11 05:10:57 UTC

[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6789: Nessie: Use latest hash for catalog APIs

ajantha-bhat commented on code in PR #6789:
URL: https://github.com/apache/iceberg/pull/6789#discussion_r1162307749


##########
nessie/src/main/java/org/apache/iceberg/nessie/UpdateableReference.java:
##########
@@ -60,13 +60,6 @@ public String getHash() {
     return reference.getHash();
   }
 
-  public Branch getAsBranch() {

Review Comment:
   I think `checkMutable` is an early check to ensure we are working on a branch which will later be modified by a commit. Whereas `getRef` or `getAsBranch` is to get the current state of the reference. I am not sure about combining them at the moment. I will explore this in a follow-up a suggested. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org