You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by km...@apache.org on 2008/12/28 22:48:11 UTC
svn commit: r729781 - in
/cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne:
modeler/dialog/db/DbLoaderHelper.java modeler/util/BrowserControl.java
modeler/util/combo/CustomTypeComboBoxEditor.java swing/BeanActionBinding.java
Author: kmenard
Date: Sun Dec 28 13:48:11 2008
New Revision: 729781
URL: http://svn.apache.org/viewvc?rev=729781&view=rev
Log:
No need to create array for vararg method calls.
Modified:
cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/dialog/db/DbLoaderHelper.java
cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/util/BrowserControl.java
cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/util/combo/CustomTypeComboBoxEditor.java
cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/swing/BeanActionBinding.java
Modified: cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/dialog/db/DbLoaderHelper.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/dialog/db/DbLoaderHelper.java?rev=729781&r1=729780&r2=729781&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/dialog/db/DbLoaderHelper.java (original)
+++ cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/dialog/db/DbLoaderHelper.java Sun Dec 28 13:48:11 2008
@@ -61,9 +61,7 @@
// TODO: this is a temp hack... need to delegate to DbAdapter, or configurable in
// preferences...
- private static final Collection EXCLUDED_TABLES = Arrays.asList(new Object[] {
- "AUTO_PK_SUPPORT", "auto_pk_support"
- });
+ private static final Collection EXCLUDED_TABLES = Arrays.asList("AUTO_PK_SUPPORT", "auto_pk_support");
static DbLoaderMergeDialog mergeDialog;
Modified: cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/util/BrowserControl.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/util/BrowserControl.java?rev=729781&r1=729780&r2=729781&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/util/BrowserControl.java (original)
+++ cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/util/BrowserControl.java Sun Dec 28 13:48:11 2008
@@ -55,7 +55,7 @@
else if (OperatingSystem.getOS() == OperatingSystem.MAC_OS_X) {
Class<?> fileManager = Class.forName("com.apple.eio.FileManager");
Method openURL = fileManager.getDeclaredMethod("openURL", String.class);
- openURL.invoke(null, new Object[] {url});
+ openURL.invoke(null, url);
}
else { // assume Unix or Linux
String[] browsers = {
Modified: cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/util/combo/CustomTypeComboBoxEditor.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/util/combo/CustomTypeComboBoxEditor.java?rev=729781&r1=729780&r2=729781&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/util/combo/CustomTypeComboBoxEditor.java (original)
+++ cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/util/combo/CustomTypeComboBoxEditor.java Sun Dec 28 13:48:11 2008
@@ -132,7 +132,7 @@
*/
try {
Method method = classTo.getMethod("valueOf", new Class[]{String.class});
- return method.invoke(null, new Object[] { value});
+ return method.invoke(null, value);
}
catch (Exception ignored) {}
Modified: cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/swing/BeanActionBinding.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/swing/BeanActionBinding.java?rev=729781&r1=729780&r2=729781&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/swing/BeanActionBinding.java (original)
+++ cayenne/main/trunk/framework/cayenne-modeler/src/main/java/org/apache/cayenne/swing/BeanActionBinding.java Sun Dec 28 13:48:11 2008
@@ -52,14 +52,11 @@
if (ActionListener.class
.isAssignableFrom(event.getListenerType())) {
- event.getAddListenerMethod().invoke(component, new Object[]{
- new ActionListener() {
-
+ event.getAddListenerMethod().invoke(component, new ActionListener() {
public void actionPerformed(ActionEvent e) {
fireAction();
}
- }
- });
+ });
foundActionEvents = true;
break;