[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator

[GitBox <gi...@apache.org>]

samskalicky commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator
URL: https://github.com/apache/incubator-mxnet/pull/15811#discussion_r317319361
 
 

 ##########
 File path: src/operator/nn/upsampling-inl.h
 ##########
 @@ -48,16 +48,18 @@ enum UpSamplingMultiInputMode {kConcat, kSum};
 }  // namespace up_enum
 
 struct UpSamplingParam : public dmlc::Parameter<UpSamplingParam> {
-  int scale;
+  TShape scale;
   int num_filter;
   int sample_type;
   int num_args;
   int multi_input_mode;
   uint64_t workspace;
   DMLC_DECLARE_PARAMETER(UpSamplingParam) {
     DMLC_DECLARE_FIELD(scale)
-    .set_range(1, 1000)
-    .describe("Up sampling scale");
+    .set_default(TShape())
 
 Review comment:
   Can you use mxnet::TShape to clarify that you're not using nnvm::TShape or vice-versa.
   
   Can you please explain how this will work for passing in a scalar argument?  I dont see TShape constructor taking a single scalar value. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services